From 82978a85c6731eb072a916cbfb8d6d807dd88fcb Mon Sep 17 00:00:00 2001 From: Geoffrey Thomas Date: Sun, 22 Sep 2024 14:44:10 -0400 Subject: [PATCH] Revert "nixos/profiles/base: install vim w/nix-syntax plugin" Adding custom plugins causes the `vim` command to be a wrapper script running `vim -u ...`, which makes it not load the default ~/.vimrc. (This is analogous to #177375 about neovim.) As of Vim 9, the syntax-highlighting portion of the nix plugin is upstream; the full plugin is only needed for indentation etc. (see also e261eb152ba8aa72a139a15e9856495ba348f8af). So, using regular pkgs.vim works around this behavior/bug and causes any ~/.vimrc to get loaded, without regressing the syntax highlighting support that motivated the change being reverted here. This reverts commit 0b5a0cbc69f18f2a123bf4ae0751ee718ef04e53. --- nixos/modules/profiles/base.nix | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/nixos/modules/profiles/base.nix b/nixos/modules/profiles/base.nix index be79bd205cb3..943f9d8e3106 100644 --- a/nixos/modules/profiles/base.nix +++ b/nixos/modules/profiles/base.nix @@ -19,13 +19,7 @@ pkgs.cryptsetup # needed for dm-crypt volumes # Some text editors. - (pkgs.vim.customize { - name = "vim"; - vimrcConfig.packages.default = { - start = [ pkgs.vimPlugins.vim-nix ]; - }; - vimrcConfig.customRC = "syntax on"; - }) + pkgs.vim # Some networking tools. pkgs.fuse