maintainers/scripts/feature-freeze-teams.pl: Use GitHub CLI

Makes it much easier and less involved to run
This commit is contained in:
Silvan Mosberger
2025-10-20 17:16:47 +02:00
parent 1aefc212a7
commit 264ca12397

View File

@@ -1,11 +1,11 @@
#!/usr/bin/env nix-shell #!/usr/bin/env nix-shell
#!nix-shell -i perl -p perl -p perlPackages.JSON perlPackages.LWPUserAgent perlPackages.LWPProtocolHttps perlPackages.TermReadKey #!nix-shell -i perl -p perl -p perlPackages.JSON github-cli
# This script generates a list of teams to ping for the Feature Freeze announcement on Discourse. # This script generates a list of teams to ping for the Feature Freeze announcement on Discourse.
# It's intended to be used by Release Managers before creating such posts. # It's intended to be used by Release Managers before creating such posts.
# #
# The script interactively reads a GitHub username and a corresponding GitHub Personal Access token. # The script uses the credentials from the GitHub CLI (gh)
# This is required to access the GitHub Teams API so the token needs at least the read:org privilege. # This is required to access the GitHub Teams API so it needs at least the read:org privilege.
## no critic (InputOutput::RequireCheckedSyscalls, InputOutput::ProhibitBacktickOperators) ## no critic (InputOutput::RequireCheckedSyscalls, InputOutput::ProhibitBacktickOperators)
use strict; use strict;
@@ -14,39 +14,21 @@ use Carp;
use Cwd 'abs_path'; use Cwd 'abs_path';
use File::Basename; use File::Basename;
use JSON qw(decode_json); use JSON qw(decode_json);
use LWP::UserAgent;
use Term::ReadKey qw(ReadLine ReadMode);
sub github_team_members { sub github_team_members {
my ($team_name, $username, $token) = @_; my ($team_name) = @_;
my @ret; my @ret;
my $req = HTTP::Request->new('GET', "https://api.github.com/orgs/NixOS/teams/$team_name/members", [ 'Accept' => 'application/vnd.github.v3+json' ]); my $content = decode_json(`gh api orgs/NixOS/teams/$team_name/members`);
$req->authorization_basic($username, $token);
my $response = LWP::UserAgent->new->request($req);
if ($response->is_success) {
my $content = decode_json($response->decoded_content);
foreach (@{$content}) { foreach (@{$content}) {
push @ret, $_->{'login'}; push @ret, $_->{'login'};
} }
} else {
print {*STDERR} "!! Requesting members of GitHub Team '$team_name' failed: " . $response->status_line;
}
return \@ret; return \@ret;
} }
# Read GitHub credentials `gh auth status` or die "`gh` comes from `pkgs.github-cli`, or in one command:
print {*STDERR} 'GitHub username: '; nix-shell -p github-cli --run 'gh auth login'\n";
my $github_user = ReadLine(0);
ReadMode('noecho');
print {*STDERR} 'GitHub personal access token (no echo): ';
my $github_token = ReadLine(0);
ReadMode('restore');
print {*STDERR} "\n";
chomp $github_user;
chomp $github_token;
# Read nix output # Read nix output
my $nix_version = `nix --version`; my $nix_version = `nix --version`;
@@ -60,7 +42,6 @@ if ($nix_version =~ m/2[.]3[.]/msx) {
my $data = decode_json($out); my $data = decode_json($out);
# Process teams # Process teams
print {*STDERR} "\n";
while (my ($team_nix_key, $team_config) = each %{$data}) { while (my ($team_nix_key, $team_config) = each %{$data}) {
# Ignore teams that don't want to be or can't be pinged # Ignore teams that don't want to be or can't be pinged
if (not defined $team_config->{enableFeatureFreezePing} or not $team_config->{enableFeatureFreezePing}) { if (not defined $team_config->{enableFeatureFreezePing} or not $team_config->{enableFeatureFreezePing}) {
@@ -76,7 +57,7 @@ while (my ($team_nix_key, $team_config) = each %{$data}) {
my @github_members; my @github_members;
if (defined $team_config->{github}) { if (defined $team_config->{github}) {
print {*STDERR} " \@NixOS/$team_config->{github}"; print {*STDERR} " \@NixOS/$team_config->{github}";
push @github_members, @{github_team_members($team_config->{github}, $github_user, $github_token)}; push @github_members, @{github_team_members($team_config->{github})};
} }
my %github_members = map { $_ => 1 } @github_members; my %github_members = map { $_ => 1 } @github_members;
# Members # Members