From 76e6b5805d6b8cc6aac30a8997119292c3559c93 Mon Sep 17 00:00:00 2001 From: Tom Wieczorek Date: Sat, 28 Oct 2023 13:05:03 +0200 Subject: [PATCH 1/2] diffoci: Add version literal to ldflags --- pkgs/tools/misc/diffoci/default.nix | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/pkgs/tools/misc/diffoci/default.nix b/pkgs/tools/misc/diffoci/default.nix index 3c7de46e01e8..afe66959fb55 100644 --- a/pkgs/tools/misc/diffoci/default.nix +++ b/pkgs/tools/misc/diffoci/default.nix @@ -16,7 +16,11 @@ buildGoModule rec { vendorHash = "sha256-4C35LBxSm6EkcOznQY1hT2vX9bwFfps/q76VqqPKBfI="; - ldflags = [ "-s" "-w" ]; + ldflags = [ + "-s" + "-w" + "-X=github.com/reproducible-containers/diffoci/cmd/diffoci/version.Version=v${version}" + ]; meta = with lib; { description = "Diff for Docker and OCI container images"; From 198c47dd90a3fab0fde53d7578cfd7992388fe69 Mon Sep 17 00:00:00 2001 From: Tom Wieczorek Date: Sat, 28 Oct 2023 13:22:39 +0200 Subject: [PATCH 2/2] diffoci: Add shell completions --- pkgs/tools/misc/diffoci/default.nix | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/pkgs/tools/misc/diffoci/default.nix b/pkgs/tools/misc/diffoci/default.nix index afe66959fb55..6337b2d500c4 100644 --- a/pkgs/tools/misc/diffoci/default.nix +++ b/pkgs/tools/misc/diffoci/default.nix @@ -1,6 +1,9 @@ { lib +, stdenv +, buildPackages , buildGoModule , fetchFromGitHub +, installShellFiles }: buildGoModule rec { @@ -22,6 +25,19 @@ buildGoModule rec { "-X=github.com/reproducible-containers/diffoci/cmd/diffoci/version.Version=v${version}" ]; + nativeBuildInputs = [ installShellFiles ]; + + postInstall = + let + diffoci = if stdenv.buildPlatform.canExecute stdenv.hostPlatform then placeholder "out" else buildPackages.diffoci; + in + '' + installShellCompletion --cmd trivy \ + --bash <(${diffoci}/bin/diffoci completion bash) \ + --fish <(${diffoci}/bin/diffoci completion fish) \ + --zsh <(${diffoci}/bin/diffoci completion zsh) + ''; + meta = with lib; { description = "Diff for Docker and OCI container images"; homepage = "https://github.com/reproducible-containers/diffoci/";