From 25362189134d69a20719d14e07f458fae4edd492 Mon Sep 17 00:00:00 2001
From: Gaetan Lepage <gaetan@glepage.com>
Date: Sun, 8 Mar 2026 17:49:37 +0000
Subject: [PATCH] python3Packages.jsonargparse: cleanup, skip failing tests

---
 .../python-modules/jsonargparse/default.nix   | 50 ++++++++++++-------
 1 file changed, 33 insertions(+), 17 deletions(-)

diff --git a/pkgs/development/python-modules/jsonargparse/default.nix b/pkgs/development/python-modules/jsonargparse/default.nix
index a7d3b265d266..23c0581a9b45 100644
--- a/pkgs/development/python-modules/jsonargparse/default.nix
+++ b/pkgs/development/python-modules/jsonargparse/default.nix
@@ -1,19 +1,29 @@
 {
   lib,
-  argcomplete,
   buildPythonPackage,
-  docstring-parser,
   fetchFromGitHub,
+  pythonAtLeast,
+
+  # build-system
+  setuptools,
+
+  # dependencies
+  pyyaml,
+
+  # optional-dependencies
+
+  # tests
+
+  argcomplete,
+  docstring-parser,
   fsspec,
   jsonnet,
   jsonschema,
   omegaconf,
   pytestCheckHook,
-  pyyaml,
   reconplogger,
   requests,
   ruyaml,
-  setuptools,
   toml,
   types-pyyaml,
   types-requests,
@@ -36,18 +46,18 @@ buildPythonPackage (finalAttrs: {
 
   dependencies = [ pyyaml ];
 
-  optional-dependencies = {
-    all = [
-      argcomplete
-      fsspec
-      jsonnet
-      jsonschema
-      omegaconf
-      ruyaml
-      docstring-parser
-      typeshed-client
-      requests
-    ];
+  optional-dependencies = lib.fix (self: {
+    all =
+      self.argcomplete
+      ++ self.fsspec
+      ++ self.jsonnet
+      ++ self.jsonschema
+      ++ self.omegaconf
+      ++ self.reconplogger
+      ++ self.ruyaml
+      ++ self.signatures
+      ++ self.toml
+      ++ self.urls;
     argcomplete = [ argcomplete ];
     fsspec = [ fsspec ];
     jsonnet = [
@@ -64,7 +74,7 @@ buildPythonPackage (finalAttrs: {
     ];
     toml = [ toml ];
     urls = [ requests ];
-  };
+  });
 
   nativeCheckInputs = [
     pytestCheckHook
@@ -72,6 +82,12 @@ buildPythonPackage (finalAttrs: {
     types-requests
   ];
 
+  disabledTests = lib.optionals (pythonAtLeast "3.14") [
+    # _pickle.PicklingError: Can't pickle local object ...
+    "test_get_argument_group_class_underscores_to_dashes"
+    "test_pickle_parser"
+  ];
+
   pythonImportsCheck = [ "jsonargparse" ];
 
   meta = {