From 9c59fd919f7eb9ee1756d4773fc5bc4d36c03064 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rafael=20Fern=C3=A1ndez=20L=C3=B3pez?= Date: Sun, 21 Aug 2022 10:44:31 +0200 Subject: [PATCH] wasmtime: disable tests on x86_64-darwin Remove tests on x86_64-darwin to avoid specific false errors due to the way Hydra runners are set up for this architecture. On this platform, on Hydra runners we see: `SIMD support requires SSE3, SSSE3, SSE4.1, and SSE4.2 on x86_64.` present in all failing tests. Thus, do not run tests on this platform to avoid false reports of this derivation being broken, because Hydra runners are set up in a way that this CPU features are not available. An example of automation marking this derivation as broken because the Hydra runs were reporting failures: 03bc5717445bbccda21d10eeecb6ded4c12d08fe. --- pkgs/development/interpreters/wasmtime/default.nix | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/pkgs/development/interpreters/wasmtime/default.nix b/pkgs/development/interpreters/wasmtime/default.nix index 9851da2a3cef..db113b2a4816 100644 --- a/pkgs/development/interpreters/wasmtime/default.nix +++ b/pkgs/development/interpreters/wasmtime/default.nix @@ -1,4 +1,4 @@ -{ rustPlatform, fetchFromGitHub, lib }: +{ rustPlatform, fetchFromGitHub, lib, stdenv }: rustPlatform.buildRustPackage rec { pname = "wasmtime"; @@ -14,7 +14,13 @@ rustPlatform.buildRustPackage rec { cargoSha256 = "sha256-DnThste0SbBdpGAUYhmwbdQFNEB3LozyDf0X8r2A90Q="; - doCheck = true; + # We disable tests on x86_64-darwin because Hydra runners do not + # support SSE3, SSSE3, SSE4.1 and SSE4.2 at this time. This is + # required by wasmtime. Given this is very specific to Hydra + # runners, just disable tests on this platform, so we don't get + # false positives of this package being broken due to failed runs on + # Hydra (e.g. https://hydra.nixos.org/build/187667794/) + doCheck = (stdenv.system != "x86_64-darwin"); checkFlags = [ "--skip=cli_tests::run_cwasm" "--skip=commands::compile::test::test_unsupported_flags_compile"