From 1d4d9facbcb00d2bce2fe15d9c8fdaa2137833eb Mon Sep 17 00:00:00 2001 From: nicoo Date: Sun, 12 May 2024 13:47:20 +0000 Subject: [PATCH] tests.testers.hasPkgConfigModules: test the `versionCheck` parameter Shell script is currently buggy and effectively ignores the value, always enforcing version match: https://github.com/NixOS/nixpkgs/pull/307770#issuecomment-2102586718 --- pkgs/build-support/testers/hasPkgConfigModules/tests.nix | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/pkgs/build-support/testers/hasPkgConfigModules/tests.nix b/pkgs/build-support/testers/hasPkgConfigModules/tests.nix index bf992d040b4b..adad93507984 100644 --- a/pkgs/build-support/testers/hasPkgConfigModules/tests.nix +++ b/pkgs/build-support/testers/hasPkgConfigModules/tests.nix @@ -11,10 +11,15 @@ lib.recurseIntoAttrs { miniz-versions-mismatch = testers.testBuildFailure (testers.hasPkgConfigModules { package = miniz; - version = "1.2.3"; + version = "1.2.3"; # Deliberately-incorrect version number versionCheck = true; }); + miniz-no-versionCheck = testers.hasPkgConfigModules { + package = miniz; + version = "1.2.3"; # Deliberately-incorrect version number + }; + zlib-has-zlib = testers.hasPkgConfigModules { package = zlib; moduleNames = [ "zlib" ];