From 1d3fd9f92d7097459bcf84e6bd0e8a401bdd16f3 Mon Sep 17 00:00:00 2001 From: Jason Yundt Date: Sun, 22 Sep 2024 17:54:18 -0400 Subject: [PATCH] msmtp: specify that msmtpq is a wrapper MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Consider this Nix expression: let pkgs = import /path/to/nixpkgs { }; in pkgs.binlore.collect { drvs = [ pkgs.msmtp ]; } Building that expression will allow you to inspect the binlore for msmtp. Before this change, the lore said that msmtpq might be able to execute its arguments. It would be more correct to say that msmtpq can run its arguments because msmtpq forwards most of its arguments to msmtp [1] and msmtp can run its arguments [2]. This commit makes sure that the msmtp package’s lore declares that the msmtpq command is a wrapper for the msmtp command. This way, anything that accesses msmtpq’s lore will know that msmtpq has the same verdict as msmtp. [1]: [2]: --- pkgs/applications/networking/msmtp/default.nix | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/pkgs/applications/networking/msmtp/default.nix b/pkgs/applications/networking/msmtp/default.nix index d2291cc1e922..885a2f826880 100644 --- a/pkgs/applications/networking/msmtp/default.nix +++ b/pkgs/applications/networking/msmtp/default.nix @@ -21,6 +21,8 @@ , systemd , withScripts ? true , gitUpdater +, binlore +, msmtp }: let @@ -139,6 +141,12 @@ if withScripts then paths = [ binaries scripts ]; passthru = { inherit binaries scripts src; + # msmtpq forwards most of its arguments to msmtp [1]. + # + # [1]: + binlore.out = binlore.synthesize msmtp '' + wrapper bin/msmtpq bin/msmtp + ''; updateScript = gitUpdater { rev-prefix = "msmtp-"; }; }; } else binaries