From 634fccb4c25be6cf03486f61aac432992ba700fa Mon Sep 17 00:00:00 2001 From: Sarah Clark Date: Fri, 27 Jun 2025 13:00:45 -0700 Subject: [PATCH 1/2] python3Packages.ibis-framework: disable tests that break only under nixpkgs-review --- pkgs/development/python-modules/ibis-framework/default.nix | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/pkgs/development/python-modules/ibis-framework/default.nix b/pkgs/development/python-modules/ibis-framework/default.nix index a68bfb2bbf0b..7c7d043f141e 100644 --- a/pkgs/development/python-modules/ibis-framework/default.nix +++ b/pkgs/development/python-modules/ibis-framework/default.nix @@ -171,6 +171,12 @@ buildPythonPackage rec { # AssertionError: value does not match the expected value in snapshot ibis/backends/tests/snapshots/test_sql/test_rewrite_context/sqlite/out.sql "test_rewrite_context" + + # Assertion error comparing a calculated version string with the actual (during nixpkgs-review) + "test_builtin_scalar_noargs" + + # duckdb ParserError: syntax error at or near "AT" + "test_90" ]; # patch out tests that check formatting with black From 695fdacd2827564cfc30812410f0026f147036dd Mon Sep 17 00:00:00 2001 From: Sarah Clark Date: Fri, 11 Jul 2025 17:21:50 -0700 Subject: [PATCH 2/2] python3Packages.ibis-framework: add sarahec as maintainer --- .../python-modules/ibis-framework/default.nix | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/pkgs/development/python-modules/ibis-framework/default.nix b/pkgs/development/python-modules/ibis-framework/default.nix index 7c7d043f141e..340b308d500c 100644 --- a/pkgs/development/python-modules/ibis-framework/default.nix +++ b/pkgs/development/python-modules/ibis-framework/default.nix @@ -112,10 +112,6 @@ buildPythonPackage rec { hatchling ]; - pythonRelaxDeps = [ - # "toolz" - ]; - dependencies = [ atpublic parsy @@ -358,6 +354,9 @@ buildPythonPackage rec { homepage = "https://github.com/ibis-project/ibis"; changelog = "https://github.com/ibis-project/ibis/blob/${version}/docs/release_notes.md"; license = lib.licenses.asl20; - maintainers = with lib.maintainers; [ cpcloud ]; + maintainers = with lib.maintainers; [ + cpcloud + sarahec + ]; }; }