From 1be7fe5e1d8521dccecbee2c1d1e20964f764502 Mon Sep 17 00:00:00 2001
From: toonn <toonn@toonn.io>
Date: Wed, 22 Jan 2025 15:05:23 +0100
Subject: [PATCH] nb: Use bashInteractive to fix shell subcommand (#375817)

The `nb shell` subcommand relies on Bash's `read` and the default Bash
in stdenv has unexpected behavior, characters aren't echoed and arrow
keys do not seem to recall history.

By adding `bashInteractive` to the buildInputs, patchShebangs picks it
up and this fixes the behavior.

Fixes #374606
---
 pkgs/by-name/nb/nb/package.nix | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/pkgs/by-name/nb/nb/package.nix b/pkgs/by-name/nb/nb/package.nix
index cde39aad99bc..7880a96faa4d 100644
--- a/pkgs/by-name/nb/nb/package.nix
+++ b/pkgs/by-name/nb/nb/package.nix
@@ -6,6 +6,7 @@
   testers,
   nix-update-script,
   nb,
+  bashInteractive,
 }:
 
 stdenv.mkDerivation rec {
@@ -21,6 +22,8 @@ stdenv.mkDerivation rec {
 
   nativeBuildInputs = [ installShellFiles ];
 
+  buildInputs = [ bashInteractive ];
+
   dontBuild = true;
 
   installPhase = ''