From 4235624542a782a43e3ed3d5acda192cea19949a Mon Sep 17 00:00:00 2001 From: Sigmanificient Date: Thu, 9 May 2024 00:55:46 +0200 Subject: [PATCH 1/2] liboqs: 0.8.0 -> 0.10.0 --- pkgs/development/libraries/liboqs/default.nix | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/pkgs/development/libraries/liboqs/default.nix b/pkgs/development/libraries/liboqs/default.nix index e703dc3647fa..13839e2a54df 100644 --- a/pkgs/development/libraries/liboqs/default.nix +++ b/pkgs/development/libraries/liboqs/default.nix @@ -3,24 +3,35 @@ stdenv, fetchFromGitHub, cmake, + ninja, openssl, + fetchpatch, enableStatic ? stdenv.hostPlatform.isStatic, }: stdenv.mkDerivation rec { pname = "liboqs"; - version = "0.8.0"; + version = "0.10.0"; src = fetchFromGitHub { owner = "open-quantum-safe"; repo = pname; rev = version; - sha256 = "sha256-h3mXoGRYgPg0wKQ1u6uFP7wlEUMQd5uIBt4Hr7vjNtA="; + sha256 = "sha256-BFDa5NUr02lFPcT4Hnb2rjGAi+2cXvh1SHLfqX/zLlI="; }; - patches = [ ./fix-openssl-detection.patch ]; + patches = [ + ./fix-openssl-detection.patch + # liboqs.pc.in path were modified in this commit + # causing malformed path with double slashes. + (fetchpatch { + url = "https://github.com/open-quantum-safe/liboqs/commit/f0e6b8646c5eae0e8052d029079ed3efa498f220.patch"; + hash = "sha256-tDfWzcDnFGikzq2ADEWiUgcUt1NSLWQ9/HVWA3rKuzc="; + revert = true; + }) + ]; - nativeBuildInputs = [ cmake ]; + nativeBuildInputs = [ cmake ninja ]; buildInputs = [ openssl ]; cmakeFlags = [ From e7694d9b4fabb51574c19a63f8b7ea30b3581032 Mon Sep 17 00:00:00 2001 From: Sigmanificient Date: Thu, 9 May 2024 01:01:40 +0200 Subject: [PATCH 2/2] liboqs: migrate to by-name --- .../li}/liboqs/fix-openssl-detection.patch | 0 .../default.nix => by-name/li/liboqs/package.nix} | 15 ++++++++------- pkgs/top-level/all-packages.nix | 2 -- 3 files changed, 8 insertions(+), 9 deletions(-) rename pkgs/{development/libraries => by-name/li}/liboqs/fix-openssl-detection.patch (100%) rename pkgs/{development/libraries/liboqs/default.nix => by-name/li/liboqs/package.nix} (83%) diff --git a/pkgs/development/libraries/liboqs/fix-openssl-detection.patch b/pkgs/by-name/li/liboqs/fix-openssl-detection.patch similarity index 100% rename from pkgs/development/libraries/liboqs/fix-openssl-detection.patch rename to pkgs/by-name/li/liboqs/fix-openssl-detection.patch diff --git a/pkgs/development/libraries/liboqs/default.nix b/pkgs/by-name/li/liboqs/package.nix similarity index 83% rename from pkgs/development/libraries/liboqs/default.nix rename to pkgs/by-name/li/liboqs/package.nix index 13839e2a54df..f6d996bc1b1d 100644 --- a/pkgs/development/libraries/liboqs/default.nix +++ b/pkgs/by-name/li/liboqs/package.nix @@ -3,21 +3,20 @@ stdenv, fetchFromGitHub, cmake, - ninja, openssl, fetchpatch, enableStatic ? stdenv.hostPlatform.isStatic, }: -stdenv.mkDerivation rec { +stdenv.mkDerivation (finalAttrs: { pname = "liboqs"; version = "0.10.0"; src = fetchFromGitHub { owner = "open-quantum-safe"; - repo = pname; - rev = version; - sha256 = "sha256-BFDa5NUr02lFPcT4Hnb2rjGAi+2cXvh1SHLfqX/zLlI="; + repo = "liboqs"; + rev = finalAttrs.version; + hash = "sha256-BFDa5NUr02lFPcT4Hnb2rjGAi+2cXvh1SHLfqX/zLlI="; }; patches = [ @@ -31,7 +30,7 @@ stdenv.mkDerivation rec { }) ]; - nativeBuildInputs = [ cmake ninja ]; + nativeBuildInputs = [ cmake ]; buildInputs = [ openssl ]; cmakeFlags = [ @@ -42,6 +41,8 @@ stdenv.mkDerivation rec { dontFixCmake = true; # fix CMake file will give an error + outputs = [ "out" "dev" ]; + meta = with lib; { description = "C library for prototyping and experimenting with quantum-resistant cryptography"; homepage = "https://openquantumsafe.org"; @@ -49,4 +50,4 @@ stdenv.mkDerivation rec { platforms = platforms.all; maintainers = [ maintainers.sigmanificient ]; }; -} +}) diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index a38897c6125b..50de92dc7ad8 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -22768,8 +22768,6 @@ with pkgs; libopusenc = callPackage ../development/libraries/libopusenc { }; - liboqs = callPackage ../development/libraries/liboqs { }; - libosinfo = callPackage ../development/libraries/libosinfo { }; libosip = callPackage ../development/libraries/osip { };