From 1af65a4adcae8091d1fb74202b877b4ed7d0aa27 Mon Sep 17 00:00:00 2001 From: Robert Hensing Date: Wed, 28 May 2025 18:39:03 +0200 Subject: [PATCH] mkDerivation: Add comment about version override check --- pkgs/stdenv/generic/make-derivation.nix | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pkgs/stdenv/generic/make-derivation.nix b/pkgs/stdenv/generic/make-derivation.nix index 9b7fdddb8683..7bd3301169c9 100644 --- a/pkgs/stdenv/generic/make-derivation.nix +++ b/pkgs/stdenv/generic/make-derivation.nix @@ -96,6 +96,9 @@ let warnForBadVersionOverride = ( thisOverlay ? version && prev ? version + # We could check that the version is actually distinct, but that + # would probably just delay the inevitable, or preserve tech debt. + # && prev.version != thisOverlay.version && !(thisOverlay ? src) && !(thisOverlay.__intentionallyOverridingVersion or false) );