From 19cb56507a7103330c6d0e4fa2b36d712ee504f8 Mon Sep 17 00:00:00 2001 From: Lin Jian Date: Wed, 5 Feb 2025 11:52:08 +0800 Subject: [PATCH] emacs: stop adding packageRequires to buildInputs According to dependency propagation rules[1], this is redundant since we already add packageRequires to propagatedBuildInputs. [1]: https://github.com/NixOS/nixpkgs/blob/730c3a8ddf044683369f6184e47a23431f19823d/doc/stdenv/stdenv.chapter.md?plain=1#L314-L344 --- pkgs/applications/editors/emacs/build-support/generic.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/applications/editors/emacs/build-support/generic.nix b/pkgs/applications/editors/emacs/build-support/generic.nix index 94f791d8f6cd..3dd047273389 100644 --- a/pkgs/applications/editors/emacs/build-support/generic.nix +++ b/pkgs/applications/editors/emacs/build-support/generic.nix @@ -67,7 +67,7 @@ libBuildHelper.extendMkDerivation' stdenv.mkDerivation ( ''; inherit packageRequires; - buildInputs = [ emacs ] ++ finalAttrs.packageRequires ++ buildInputs; + buildInputs = [ emacs ] ++ buildInputs; nativeBuildInputs = [ emacs texinfo