From 18e84362b63808822ff4069465857449fd7a1efd Mon Sep 17 00:00:00 2001 From: Florian Klink Date: Sat, 8 Mar 2025 17:49:15 +0700 Subject: [PATCH] mkBinaryCache: add missing .nar extension Flagged in https://github.com/NixOS/nixpkgs/pull/376365#discussion_r1976613767. This now properly restores the .nar extension. --- pkgs/build-support/binary-cache/make-binary-cache.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/build-support/binary-cache/make-binary-cache.py b/pkgs/build-support/binary-cache/make-binary-cache.py index 8b774cf65adb..9104d64a46d0 100644 --- a/pkgs/build-support/binary-cache/make-binary-cache.py +++ b/pkgs/build-support/binary-cache/make-binary-cache.py @@ -16,7 +16,7 @@ def processItem( ): narInfoHash = dropPrefix(item["path"], nixPrefix).split("-")[0] - narFile = outDir / "nar" / f"{narInfoHash}{compressionExtension}" + narFile = outDir / "nar" / f"{narInfoHash}.nar{compressionExtension}" with open(narFile, "wb") as f: subprocess.run( f"nix-store --dump {item['path']} {compressionCommand}", @@ -36,7 +36,7 @@ def processItem( ) fileSize = os.path.getsize(narFile) - finalNarFileName = Path("nar") / f"{fileHash}{compressionExtension}" + finalNarFileName = Path("nar") / f"{fileHash}.nar{compressionExtension}" os.rename(narFile, outDir / finalNarFileName) with open(outDir / f"{narInfoHash}.narinfo", "wt") as f: