gador/nixpkgs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

maintainers/scripts/haskell: optimise calculateReverseDependencies

Browse Source 
Use an IntMap rather than a list for the fixpoint computation.
This commit is contained in:
Naïm Favier
2024-01-14 17:46:48 +01:00
parent afb843b80f
commit 18456d10ef
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
maintainers/scripts/haskell/hydra-report.hs
View File

@@ -83,7 +83,7 @@ import Prelude hiding (id)
import Data.List (sortOn) import Data.List (sortOn)
import Control.Concurrent.Async (concurrently) import Control.Concurrent.Async (concurrently)
import Control.Exception (evaluate) import Control.Exception (evaluate)
import qualified Data.IntMap.Strict as IntMap import qualified Data.IntMap.Lazy as IntMap
import qualified Data.IntSet as IntSet import qualified Data.IntSet as IntSet
import Data.Bifunctor (second) import Data.Bifunctor (second)
import Data.Data (Proxy) import Data.Data (Proxy)
@@ -299,7 +299,7 @@ calculateReverseDependencies depMap =
Map.fromDistinctAscList $ zip keys (zip (rdepMap False) (rdepMap True)) Map.fromDistinctAscList $ zip keys (zip (rdepMap False) (rdepMap True))
where where
-- This code tries to efficiently invert the dependency map and calculate -- This code tries to efficiently invert the dependency map and calculate
-- it’s transitive closure by internally identifying every pkg with it’s index -- its transitive closure by internally identifying every pkg with its index
-- in the package list and then using memoization. -- in the package list and then using memoization.
keys :: [PkgName] keys :: [PkgName]
keys = Map.keys depMap keys = Map.keys depMap
@@ -317,11 +317,11 @@ calculateReverseDependencies depMap =
intDeps :: [(Int, (Bool, [Int]))] intDeps :: [(Int, (Bool, [Int]))]
intDeps = zip [0..] (fmap depInfoToIdx depInfos) intDeps = zip [0..] (fmap depInfoToIdx depInfos)
rdepMap onlyUnbroken = IntSet.size <$> resultList rdepMap onlyUnbroken = IntSet.size <$> IntMap.elems resultList
where where
resultList = go <$> [0..] resultList = IntMap.fromDistinctAscList [(i, go i) | i <- [0..length keys - 1]]
oneStepMap = IntMap.fromListWith IntSet.union $ (\(key,(_,deps)) -> (,IntSet.singleton key) <$> deps) <=< filter (\(_, (broken,_)) -> not (broken && onlyUnbroken)) $ intDeps oneStepMap = IntMap.fromListWith IntSet.union $ (\(key,(_,deps)) -> (,IntSet.singleton key) <$> deps) <=< filter (\(_, (broken,_)) -> not (broken && onlyUnbroken)) $ intDeps
go pkg = IntSet.unions (oneStep:((resultList !!) <$> IntSet.toList oneStep)) go pkg = IntSet.unions (oneStep:((resultList IntMap.!) <$> IntSet.toList oneStep))
where oneStep = IntMap.findWithDefault mempty pkg oneStepMap where oneStep = IntMap.findWithDefault mempty pkg oneStepMap
-- | Generate a mapping of Hydra job names to maintainer GitHub handles. Calls -- | Generate a mapping of Hydra job names to maintainer GitHub handles. Calls