From 0d75f35bc4ae3bd7187896d2fa4b5672428b6a65 Mon Sep 17 00:00:00 2001 From: Reno Dakota <170618376+paparodeo@users.noreply.github.com> Date: Thu, 24 Oct 2024 19:27:23 +0000 Subject: [PATCH] gtk4: fix x64 darwin use 10.15 sdk to fix build and propagate the sdk and min sdk version (10.15) --- pkgs/development/libraries/gtk/4.x.nix | 16 +++++++++------- pkgs/top-level/all-packages.nix | 4 +--- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/pkgs/development/libraries/gtk/4.x.nix b/pkgs/development/libraries/gtk/4.x.nix index 0de95e8ef8f9..c60f1f880437 100644 --- a/pkgs/development/libraries/gtk/4.x.nix +++ b/pkgs/development/libraries/gtk/4.x.nix @@ -50,11 +50,12 @@ , cupsSupport ? stdenv.hostPlatform.isLinux , compileSchemas ? stdenv.hostPlatform.emulatorAvailable buildPackages , cups -, AppKit -, Cocoa , libexecinfo , broadwaySupport ? true , testers +, apple-sdk +, apple-sdk_10_15 +, darwinMinVersionHook }: let @@ -131,9 +132,7 @@ stdenv.mkDerivation (finalAttrs: { libXi libXrandr libXrender - ]) ++ lib.optionals stdenv.hostPlatform.isDarwin [ - AppKit - ] ++ lib.optionals trackerSupport [ + ]) ++ lib.optionals trackerSupport [ tinysparql ] ++ lib.optionals waylandSupport [ libGL @@ -143,8 +142,6 @@ stdenv.mkDerivation (finalAttrs: { xorg.libXinerama ] ++ lib.optionals cupsSupport [ cups - ] ++ lib.optionals stdenv.hostPlatform.isDarwin [ - Cocoa ] ++ lib.optionals stdenv.hostPlatform.isMusl [ libexecinfo ]; @@ -165,6 +162,11 @@ stdenv.mkDerivation (finalAttrs: { # Required for GSettings schemas at runtime. # Will be picked up by wrapGAppsHook4. gsettings-desktop-schemas + ] ++ lib.optionals stdenv.hostPlatform.isDarwin [ + (darwinMinVersionHook "15.0") + ] ++ lib.optionals (stdenv.hostPlatform.isDarwin + && lib.versionOlder apple-sdk.version "10.15") [ + apple-sdk_10_15 ]; mesonFlags = [ diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index 8920306e82d8..357a2a28d78b 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -20052,9 +20052,7 @@ with pkgs; inherit (darwin.apple_sdk.frameworks) AppKit Cocoa QuartzCore; }; - gtk4 = callPackage ../development/libraries/gtk/4.x.nix { - inherit (darwin.apple_sdk.frameworks) AppKit Cocoa; - }; + gtk4 = callPackage ../development/libraries/gtk/4.x.nix { }; # On darwin gtk uses cocoa by default instead of x11.