From b80884dcae0fa6fd2d089f7692f24bc9fbab9dc2 Mon Sep 17 00:00:00 2001 From: Sefa Eyeoglu Date: Sat, 13 Jul 2024 16:03:49 +0200 Subject: [PATCH 1/2] root: format shell.nix Signed-off-by: Sefa Eyeoglu --- shell.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/shell.nix b/shell.nix index d9e94eb2816d..b6480290b650 100644 --- a/shell.nix +++ b/shell.nix @@ -17,8 +17,8 @@ let pkgs = import nixpkgs { inherit system; - config = {}; - overlays = []; + config = { }; + overlays = [ ]; }; in pkgs.mkShellNoCC { From f696c9602804fee34684cdbdd43a97d81f13c38b Mon Sep 17 00:00:00 2001 From: Sefa Eyeoglu Date: Sat, 13 Jul 2024 16:04:05 +0200 Subject: [PATCH 2/2] root: add nixpkgs-review to shell.nix nixpkgs-review is endorsed in CONTRIBUTING.md, as well as in the default PR description template. It would be very useful to include this utility in our shell.nix. Signed-off-by: Sefa Eyeoglu --- shell.nix | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/shell.nix b/shell.nix index b6480290b650..db447040db9d 100644 --- a/shell.nix +++ b/shell.nix @@ -22,9 +22,12 @@ let }; in pkgs.mkShellNoCC { - packages = [ + packages = with pkgs; [ # The default formatter for Nix code - # https://github.com/NixOS/nixfmt - pkgs.nixfmt-rfc-style + # See https://github.com/NixOS/nixfmt + nixfmt-rfc-style + # Helper to review Nixpkgs PRs + # See CONTRIBUTING.md + nixpkgs-review ]; }