From 31f1a1a0052fb0824f98b060e66406029397b7d0 Mon Sep 17 00:00:00 2001 From: Gaetan Lepage Date: Thu, 31 Oct 2024 15:20:02 +0100 Subject: [PATCH 1/2] python312Packages.botorch: disable failing test on aarch64-darwin --- pkgs/development/python-modules/botorch/default.nix | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/pkgs/development/python-modules/botorch/default.nix b/pkgs/development/python-modules/botorch/default.nix index 1cf11d17eb50..9970378d3741 100644 --- a/pkgs/development/python-modules/botorch/default.nix +++ b/pkgs/development/python-modules/botorch/default.nix @@ -58,6 +58,11 @@ buildPythonPackage rec { ++ lib.optionals (stdenv.buildPlatform.system == "x86_64-linux") [ # stuck tests on hydra "test_moo_predictive_entropy_search" + ] + ++ lib.optionals (stdenv.hostPlatform.isDarwin && stdenv.isAarch64) [ + # Numerical error slightly above threshold + # AssertionError: Tensor-likes are not close! + "test_model_list_gpytorch_model" ]; pythonImportsCheck = [ "botorch" ]; @@ -65,11 +70,11 @@ buildPythonPackage rec { # needs lots of undisturbed CPU time or prone to getting stuck requiredSystemFeatures = [ "big-parallel" ]; - meta = with lib; { + meta = { changelog = "https://github.com/pytorch/botorch/blob/${src.rev}/CHANGELOG.md"; description = "Bayesian Optimization in PyTorch"; homepage = "https://botorch.org"; - license = licenses.mit; - maintainers = with maintainers; [ veprbl ]; + license = lib.licenses.mit; + maintainers = with lib.maintainers; [ veprbl ]; }; } From afd185164c5cb0202fe6234c30e1e5c5ae9d5354 Mon Sep 17 00:00:00 2001 From: Gaetan Lepage Date: Thu, 31 Oct 2024 15:39:23 +0100 Subject: [PATCH 2/2] python312Packages.ax-platform: add missing test dependency sqlalchemy; disable failing test --- pkgs/development/python-modules/ax-platform/default.nix | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/pkgs/development/python-modules/ax-platform/default.nix b/pkgs/development/python-modules/ax-platform/default.nix index 495a13a43b91..7f98a4978249 100644 --- a/pkgs/development/python-modules/ax-platform/default.nix +++ b/pkgs/development/python-modules/ax-platform/default.nix @@ -62,6 +62,7 @@ buildPythonPackage rec { "--ignore=ax/core/tests/test_utils.py" "--ignore=ax/early_stopping/tests/test_strategies.py" # broken with sqlalchemy 2 + "--ignore=ax/core/tests/test_experiment.py" "--ignore=ax/service/tests/test_ax_client.py" "--ignore=ax/service/tests/test_scheduler.py" "--ignore=ax/service/tests/test_with_db_settings_base.py" @@ -79,11 +80,11 @@ buildPythonPackage rec { ]; pythonImportsCheck = [ "ax" ]; - meta = with lib; { + meta = { changelog = "https://github.com/facebook/Ax/releases/tag/${version}"; description = "Ax is an accessible, general-purpose platform for understanding, managing, deploying, and automating adaptive experiments"; homepage = "https://ax.dev/"; - license = licenses.mit; - maintainers = with maintainers; [ veprbl ]; + license = lib.licenses.mit; + maintainers = with lib.maintainers; [ veprbl ]; }; }