lib/modules: Minor performance optimisation

Co-Authored-By: Johannes Kirschbauer <hsjobeki@gmail.com>

lib/modules.nix

@@ -763,17 +763,24 @@ let
               };
             };
 
-          mergedType' =
-            if mergedType ? functor.wrappedDeprecationMessage then
-              addDeprecatedWrapped mergedType
-            else
-              mergedType;
-
           typeSet =
-            if (bothHave "type") && typesMergeable then
+            if opt.options ? type then
-              { type = mergedType'; }
+              if res ? type then
-            else if opt.options ? type && opt.options.type ? functor.wrappedDeprecationMessage then
+                if typesMergeable then
-              { type = addDeprecatedWrapped opt.options.type; }
+                  {
+                    type =
+                      if mergedType ? functor.wrappedDeprecationMessage then
+                        addDeprecatedWrapped mergedType
+                      else
+                        mergedType;
+                  }
+                else
+                  # Keep in sync with the same error below!
+                  throw "The option `${showOption loc}' in `${opt._file}' is already declared in ${showFiles res.declarations}."
+              else if opt.options.type ? functor.wrappedDeprecationMessage then
+                { type = addDeprecatedWrapped opt.options.type; }
+              else
+                {}
             else
               {};
 
@@ -782,9 +789,9 @@ let
       if bothHave "default" ||
          bothHave "example" ||
          bothHave "description" ||
-         bothHave "apply" ||
+         bothHave "apply"
-         (bothHave "type" && (! typesMergeable))
       then
+        # Keep in sync with the same error above!
         throw "The option `${showOption loc}' in `${opt._file}' is already declared in ${showFiles res.declarations}."
       else
         let