From ec96063dce17cc8495e6596b8e496f483e65c256 Mon Sep 17 00:00:00 2001 From: Weijia Wang <9713184+wegank@users.noreply.github.com> Date: Sun, 10 Mar 2024 00:04:02 +0100 Subject: [PATCH 1/2] nicotine-plus: migrate to gtk4 --- .../networking/soulseek/nicotine-plus/default.nix | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/pkgs/applications/networking/soulseek/nicotine-plus/default.nix b/pkgs/applications/networking/soulseek/nicotine-plus/default.nix index 40b8252b47c0..dad01456ba73 100644 --- a/pkgs/applications/networking/soulseek/nicotine-plus/default.nix +++ b/pkgs/applications/networking/soulseek/nicotine-plus/default.nix @@ -1,11 +1,10 @@ { lib -, stdenv , fetchFromGitHub -, wrapGAppsHook +, wrapGAppsHook4 , gdk-pixbuf , gettext , gobject-introspection -, gtk3 +, gtk4 , python3Packages }: @@ -17,15 +16,15 @@ python3Packages.buildPythonApplication rec { owner = "nicotine-plus"; repo = "nicotine-plus"; rev = "refs/tags/${version}"; - sha256 = "sha256-dl4fTa+CXsycC+hhSkIzQQxrSkBDPsdrmKdrHPakGig="; + hash = "sha256-dl4fTa+CXsycC+hhSkIzQQxrSkBDPsdrmKdrHPakGig="; }; - nativeBuildInputs = [ gettext wrapGAppsHook gobject-introspection ]; + nativeBuildInputs = [ gettext wrapGAppsHook4 gobject-introspection ]; propagatedBuildInputs = [ gdk-pixbuf gobject-introspection - gtk3 + gtk4 python3Packages.pygobject3 ]; @@ -35,14 +34,13 @@ python3Packages.buildPythonApplication rec { preFixup = '' gappsWrapperArgs+=( - --prefix XDG_DATA_DIRS : "${gtk3}/share/gsettings-schemas/${gtk3.name}" + --prefix XDG_DATA_DIRS : "${gtk4}/share/gsettings-schemas/${gtk4.name}" ) ''; doCheck = false; meta = with lib; { - broken = stdenv.isDarwin; description = "A graphical client for the SoulSeek peer-to-peer system"; longDescription = '' Nicotine+ aims to be a pleasant, free and open source (FOSS) alternative From 9e119fe382c098b89d57b687baff77bb0c006bb3 Mon Sep 17 00:00:00 2001 From: Weijia Wang <9713184+wegank@users.noreply.github.com> Date: Sun, 10 Mar 2024 00:05:08 +0100 Subject: [PATCH 2/2] nicotine-plus: move to pkgs/by-name --- .../default.nix => by-name/ni/nicotine-plus/package.nix} | 0 pkgs/top-level/all-packages.nix | 2 -- 2 files changed, 2 deletions(-) rename pkgs/{applications/networking/soulseek/nicotine-plus/default.nix => by-name/ni/nicotine-plus/package.nix} (100%) diff --git a/pkgs/applications/networking/soulseek/nicotine-plus/default.nix b/pkgs/by-name/ni/nicotine-plus/package.nix similarity index 100% rename from pkgs/applications/networking/soulseek/nicotine-plus/default.nix rename to pkgs/by-name/ni/nicotine-plus/package.nix diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index 7951a6b94de3..0814814d5180 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -33638,8 +33638,6 @@ with pkgs; webkitgtk = webkitgtk_6_0; }; - nicotine-plus = callPackage ../applications/networking/soulseek/nicotine-plus { }; - nice-dcv-client = callPackage ../applications/networking/remote/nice-dcv-client { }; nixos-shell = callPackage ../tools/virtualization/nixos-shell { };