From 101c6df67b2dd214f797585fab07a83749ded36c Mon Sep 17 00:00:00 2001 From: Maximilian Bosch Date: Sun, 6 Jul 2025 10:13:24 +0200 Subject: [PATCH] postgresqlPackages.pg_net: remove general -Wno-error I wondered if this is strictly needed and it turns out that except from the postgresql_18 version failing with pg_net> src/worker.c:20:14: error: no previous extern declaration for non-static variable 'worker_state' [-Werror,-Wmissing-variable-declarations] pg_net> 20 | WorkerState *worker_state = NULL; pg_net> | ^ pg_net> src/worker.c:20:1: note: declare 'static' if the variable is not intended to be used outside of this translation unit pg_net> 20 | WorkerState *worker_state = NULL; pg_net> | ^ pg_net> 1 error generated. pg_net> make: *** [: src/worker.o] Error 1 the package builds without it. --- pkgs/servers/sql/postgresql/ext/pg_net.nix | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pkgs/servers/sql/postgresql/ext/pg_net.nix b/pkgs/servers/sql/postgresql/ext/pg_net.nix index 2249f0563892..c754b7104f43 100644 --- a/pkgs/servers/sql/postgresql/ext/pg_net.nix +++ b/pkgs/servers/sql/postgresql/ext/pg_net.nix @@ -19,7 +19,9 @@ postgresqlBuildExtension (finalAttrs: { buildInputs = [ curl ]; - env.NIX_CFLAGS_COMPILE = "-Wno-error"; + env.NIX_CFLAGS_COMPILE = toString ( + lib.optional (lib.versionAtLeast postgresql.version "18") "-Wno-error=missing-variable-declarations" + ); meta = { description = "Async networking for Postgres";