From 0f7d42cf720c9dc800bfbb4ef1f4b39b8f4da3f7 Mon Sep 17 00:00:00 2001 From: Alyssa Ross Date: Sun, 8 Mar 2026 11:59:03 +0100 Subject: [PATCH] dino: re-add gst-plugins-good input This was previously removed when experimental features in Dino were disabled, along with other dependencies required for those. Unlike the others, though, VP9 is a stable feature, which we inadvertently lost when making that change. This is therefore a partial revert of that change. Fixes: ccc6c1ca888c ("dino: disable optional features per default as they are experimental") Closes: https://github.com/NixOS/nixpkgs/issues/497706 --- .../networking/instant-messengers/dino/default.nix | 9 ++++++--- pkgs/top-level/all-packages.nix | 8 +++++++- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/pkgs/applications/networking/instant-messengers/dino/default.nix b/pkgs/applications/networking/instant-messengers/dino/default.nix index f3b68cfcd1c2..d343c7dedc2c 100644 --- a/pkgs/applications/networking/instant-messengers/dino/default.nix +++ b/pkgs/applications/networking/instant-messengers/dino/default.nix @@ -27,7 +27,9 @@ srtp, libnice, gnutls, - gst_all_1, + gstreamer, + gst-plugins-base, + gst-plugins-good, webrtc-audio-processing, }: @@ -79,8 +81,9 @@ stdenv.mkDerivation (finalAttrs: { srtp libnice gnutls - gst_all_1.gstreamer - gst_all_1.gst-plugins-base + gstreamer + gst-plugins-base + gst-plugins-good # contains rtpbin, required for VP9 webrtc-audio-processing ]; diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index e3a4627bc111..5a633884443b 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -1672,7 +1672,13 @@ with pkgs; plugins = lib.filter (p: p ? pluginName) (builtins.attrValues discourse.plugins); }; - dino = callPackage ../applications/networking/instant-messengers/dino { }; + dino = callPackage ../applications/networking/instant-messengers/dino { + inherit (gst_all_1) + gstreamer + gst-plugins-base + ; + gst-plugins-good = gst_all_1.gst-plugins-good.override { gtkSupport = true; }; + }; inherit (ocamlPackages) dot-merlin-reader;