From fc85cd76829493197f1b6d7de5445f5946742349 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Robert=20Sch=C3=BCtz?= Date: Thu, 23 Oct 2025 17:17:32 -0700 Subject: [PATCH 1/2] perlPackages.ImageExifTool: 13.25 -> 13.39 Diff: https://github.com/exiftool/exiftool/compare/13.25...13.39 Changelog: https://github.com/exiftool/exiftool/blob/13.39/Changes --- .../perl-modules/ImageExifTool/default.nix | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/pkgs/development/perl-modules/ImageExifTool/default.nix b/pkgs/development/perl-modules/ImageExifTool/default.nix index 073cb0423682..3fbc9517de02 100644 --- a/pkgs/development/perl-modules/ImageExifTool/default.nix +++ b/pkgs/development/perl-modules/ImageExifTool/default.nix @@ -1,7 +1,7 @@ { buildPerlPackage, exiftool, - fetchurl, + fetchFromGitHub, gitUpdater, lib, shortenPerlShebang, @@ -11,11 +11,13 @@ buildPerlPackage rec { pname = "Image-ExifTool"; - version = "13.25"; + version = "13.39"; - src = fetchurl { - url = "https://exiftool.org/Image-ExifTool-${version}.tar.gz"; - hash = "sha256-HNVVFEhGooKYeDvr86tFIjUnPHg1hBCBPj1Ok8ZTsfo="; + src = fetchFromGitHub { + owner = "exiftool"; + repo = "exiftool"; + tag = version; + hash = "sha256-GPm3HOt7fNMbXRrV5V+ykJAfhww1O6NrD0l/7hA2i28="; }; nativeBuildInputs = lib.optional stdenv.hostPlatform.isDarwin shortenPerlShebang; @@ -34,7 +36,7 @@ buildPerlPackage rec { command = "${lib.getExe exiftool} -ver"; package = exiftool; }; - updateScript = gitUpdater { url = "https://github.com/exiftool/exiftool.git"; }; + updateScript = gitUpdater { }; }; meta = { From b58cb912e388f596db97536b8acf17b1747a0110 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Robert=20Sch=C3=BCtz?= Date: Thu, 23 Oct 2025 17:18:56 -0700 Subject: [PATCH 2/2] perlPackages.ImageExifTool: use versionCheckHook --- .../perl-modules/ImageExifTool/default.nix | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/pkgs/development/perl-modules/ImageExifTool/default.nix b/pkgs/development/perl-modules/ImageExifTool/default.nix index 3fbc9517de02..b264606cd05a 100644 --- a/pkgs/development/perl-modules/ImageExifTool/default.nix +++ b/pkgs/development/perl-modules/ImageExifTool/default.nix @@ -1,12 +1,11 @@ { buildPerlPackage, - exiftool, fetchFromGitHub, gitUpdater, lib, shortenPerlShebang, stdenv, - testers, + versionCheckHook, }: buildPerlPackage rec { @@ -30,12 +29,11 @@ buildPerlPackage rec { shortenPerlShebang $out/bin/exiftool ''; + doInstallCheck = true; + nativeInstallCheckInputs = [ versionCheckHook ]; + versionCheckProgramArg = "-ver"; + passthru = { - tests.version = testers.testVersion { - inherit version; - command = "${lib.getExe exiftool} -ver"; - package = exiftool; - }; updateScript = gitUpdater { }; };