From 0efccf1dd9dc8d02c9aed4371e12c6711323d02f Mon Sep 17 00:00:00 2001 From: Yueh-Shun Li Date: Sat, 28 Mar 2026 23:39:37 +0800 Subject: [PATCH] buildEnv: remove redundant pname-version-name assertion Delegate such a check to stdenv.mkDerivation. --- pkgs/build-support/buildenv/default.nix | 4 ---- pkgs/test/buildenv.nix | 2 -- 2 files changed, 6 deletions(-) diff --git a/pkgs/build-support/buildenv/default.nix b/pkgs/build-support/buildenv/default.nix index 08a271080655..9b7a828b8293 100644 --- a/pkgs/build-support/buildenv/default.nix +++ b/pkgs/build-support/buildenv/default.nix @@ -121,10 +121,6 @@ lib.makeOverridable ( (lib.remove null) ]; in - assert - args ? name - || (args ? pname && args ? version) - || throw "buildEnv: expects arguments 'pname' and 'version', or 'name'"; compatArgs // derivationArgs // { diff --git a/pkgs/test/buildenv.nix b/pkgs/test/buildenv.nix index 3d4f1477c49a..8ca7a1d7b2e4 100644 --- a/pkgs/test/buildenv.nix +++ b/pkgs/test/buildenv.nix @@ -34,8 +34,6 @@ let }).name; expected = "test-env-1.0"; }; - - testMissingNameThrows = testingThrow (buildEnv { paths = [ ]; }).drvPath; }; tests-passthru-paths = {