From fd565b8c6016e681663bd80c5c4a6737403f493f Mon Sep 17 00:00:00 2001 From: Pol Dellaiera Date: Sat, 5 Apr 2025 10:10:47 +0200 Subject: [PATCH 1/2] jujutsu: use `finalAttrs` pattern --- pkgs/by-name/ju/jujutsu/package.nix | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/pkgs/by-name/ju/jujutsu/package.nix b/pkgs/by-name/ju/jujutsu/package.nix index 54634945b0c1..5e4fac2a8450 100644 --- a/pkgs/by-name/ju/jujutsu/package.nix +++ b/pkgs/by-name/ju/jujutsu/package.nix @@ -18,18 +18,14 @@ jujutsu, }: -let - version = "0.28.1"; -in - -rustPlatform.buildRustPackage { +rustPlatform.buildRustPackage (finalAttrs: { pname = "jujutsu"; - inherit version; + version = "0.28.1"; src = fetchFromGitHub { owner = "jj-vcs"; repo = "jj"; - tag = "v${version}"; + tag = "v${finalAttrs.version}"; hash = "sha256-LDMHMFg9fjEMi8I2Fc3TEyWMctqJurAbckubCgkkZiM="; }; @@ -104,7 +100,7 @@ rustPlatform.buildRustPackage { meta = { description = "Git-compatible DVCS that is both simple and powerful"; homepage = "https://github.com/jj-vcs/jj"; - changelog = "https://github.com/jj-vcs/jj/blob/v${version}/CHANGELOG.md"; + changelog = "https://github.com/jj-vcs/jj/blob/v${finalAttrs.version}/CHANGELOG.md"; license = lib.licenses.asl20; maintainers = with lib.maintainers; [ _0x4A6F @@ -114,4 +110,4 @@ rustPlatform.buildRustPackage { ]; mainProgram = "jj"; }; -} +}) From c69453acaf8d0df2c9ad2cf710169c0fc57c5fed Mon Sep 17 00:00:00 2001 From: Pol Dellaiera Date: Sat, 5 Apr 2025 10:11:28 +0200 Subject: [PATCH 2/2] jujutsu: use `versionCheckHook` --- pkgs/by-name/ju/jujutsu/package.nix | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/pkgs/by-name/ju/jujutsu/package.nix b/pkgs/by-name/ju/jujutsu/package.nix index 5e4fac2a8450..57e3b780b83d 100644 --- a/pkgs/by-name/ju/jujutsu/package.nix +++ b/pkgs/by-name/ju/jujutsu/package.nix @@ -14,8 +14,7 @@ openssh, buildPackages, nix-update-script, - testers, - jujutsu, + versionCheckHook, }: rustPlatform.buildRustPackage (finalAttrs: { @@ -87,14 +86,13 @@ rustPlatform.buildRustPackage (finalAttrs: { --zsh <(COMPLETE=zsh ${jj}) ''; + doInstallCheck = true; + nativeInstallCheckInputs = [ versionCheckHook ]; + versionCheckProgram = "${placeholder "out"}/bin/jj"; + versionCheckProgramArg = "--version"; + passthru = { updateScript = nix-update-script { }; - tests = { - version = testers.testVersion { - package = jujutsu; - command = "jj --version"; - }; - }; }; meta = {