From a4a43c399c4bac2bd20997bf71e08eb32d4ccccd Mon Sep 17 00:00:00 2001 From: Doron Behar Date: Fri, 15 Mar 2024 19:16:29 +0200 Subject: [PATCH 1/3] libtins: 4.4 -> 4.5 Diff: https://github.com/mfontanini/libtins/compare/v4.4...v4.5 Changelog: https://raw.githubusercontent.com/mfontanini/libtins/v4.5/CHANGES.md Close #255639 --- pkgs/development/libraries/libtins/default.nix | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/pkgs/development/libraries/libtins/default.nix b/pkgs/development/libraries/libtins/default.nix index 1533794bcd1e..dbb4f4d471d0 100644 --- a/pkgs/development/libraries/libtins/default.nix +++ b/pkgs/development/libraries/libtins/default.nix @@ -1,25 +1,17 @@ -{ boost, cmake, fetchFromGitHub, fetchpatch, gtest, libpcap, openssl, lib, stdenv }: +{ boost, cmake, fetchFromGitHub, gtest, libpcap, openssl, lib, stdenv }: stdenv.mkDerivation rec { pname = "libtins"; - version = "4.4"; + version = "4.5"; src = fetchFromGitHub { owner = "mfontanini"; repo = pname; rev = "v${version}"; - sha256 = "sha256-mXbinXh/CO0SZZ71+K+FozbHCCoi12+AIa2o+P0QmUw="; + sha256 = "sha256-zL4C2Cgs9Y3NebL8MPQBO5j8Bm6xhl8ZggQBPJLRn0o="; }; patches = [ - # Pull gcc-13 fixes: - # https://github.com/mfontanini/libtins/pull/496 - # TODO: remove when upgrade to the next version. - (fetchpatch { - name = "gcc-13.patch"; - url = "https://github.com/mfontanini/libtins/commit/812be7966d445ec56e88eab512f8fd2d57152427.patch"; - hash = "sha256-5RCFPe95r1CBrAocjTPR2SvUlgaGa1aBc8RazyxUj3M="; - }) # Required for gtest 1.13+. ./0001-force-cpp-14.patch ]; From 12128314a4445af577222836c9d5e4a78eb004f5 Mon Sep 17 00:00:00 2001 From: Doron Behar Date: Fri, 15 Mar 2024 19:39:52 +0200 Subject: [PATCH 2/3] libtins: mention upstream issue with gtest --- pkgs/development/libraries/libtins/default.nix | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pkgs/development/libraries/libtins/default.nix b/pkgs/development/libraries/libtins/default.nix index dbb4f4d471d0..6f195615551f 100644 --- a/pkgs/development/libraries/libtins/default.nix +++ b/pkgs/development/libraries/libtins/default.nix @@ -12,7 +12,8 @@ stdenv.mkDerivation rec { }; patches = [ - # Required for gtest 1.13+. + # Required for gtest 1.13+, see also upstream report at: + # https://github.com/mfontanini/libtins/issues/529 ./0001-force-cpp-14.patch ]; From 113f140a152297ca55e364228f5b63ca6bddd360 Mon Sep 17 00:00:00 2001 From: Doron Behar Date: Fri, 15 Mar 2024 19:30:43 +0200 Subject: [PATCH 3/3] compactor: don't overuse pname --- pkgs/applications/networking/compactor/default.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/applications/networking/compactor/default.nix b/pkgs/applications/networking/compactor/default.nix index 84c0f6ae8ba5..12e6f432c5bd 100644 --- a/pkgs/applications/networking/compactor/default.nix +++ b/pkgs/applications/networking/compactor/default.nix @@ -10,7 +10,7 @@ stdenv.mkDerivation rec { src = fetchFromGitHub { owner = "dns-stats"; - repo = pname; + repo = "compactor"; rev = version; fetchSubmodules = true; hash = "sha256-5Z14suhO5ghhmZsSj4DsSoKm+ct2gQFO6qxhjmx4Xm4="; @@ -68,7 +68,7 @@ stdenv.mkDerivation rec { meta = with lib; { description = "Tools to capture DNS traffic and record it in C-DNS files"; homepage = "https://dns-stats.org/"; - changelog = "https://github.com/dns-stats/${pname}/raw/${version}/ChangeLog.txt"; + changelog = "https://github.com/dns-stats/compactor/raw/${version}/ChangeLog.txt"; license = licenses.mpl20; maintainers = with maintainers; [ fdns ]; platforms = platforms.unix;