From 0b85c40042d88d47ee5af62628c8078cefbb7d4e Mon Sep 17 00:00:00 2001 From: Kris Budde Date: Sat, 11 May 2024 21:56:38 +0200 Subject: [PATCH] harden package definition --- pkgs/by-name/my/myks/package.nix | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/pkgs/by-name/my/myks/package.nix b/pkgs/by-name/my/myks/package.nix index 6fd19e6e8c51..6de9faf4e9c3 100644 --- a/pkgs/by-name/my/myks/package.nix +++ b/pkgs/by-name/my/myks/package.nix @@ -1,4 +1,10 @@ -{ lib, buildGoModule, fetchFromGitHub, testers, installShellFiles, myks, stdenv +{ lib, + buildGoModule, + fetchFromGitHub, + testers, + installShellFiles, + myks, + stdenv, }: buildGoModule rec { @@ -8,7 +14,7 @@ buildGoModule rec { src = fetchFromGitHub { owner = "mykso"; repo = "myks"; - rev = "v${version}"; + rev = "refs/tags/v${version}"; hash = "sha256-PaA8j4BWijhPR3DTZ0nnO54v0Uj/DpFdJpofseTA1+A="; }; @@ -19,9 +25,9 @@ buildGoModule rec { ldflags = [ "-s" "-w" - "-X main.version=${version}" - "-X main.commit=nixpkg-${src.rev}" - "-X main.date=1970-01-01" + "-X=main.version=${version}" + "-X=main.commit=nixpkg-${version}" + "-X=main.date=1970-01-01" ]; nativeBuildInputs = [ installShellFiles ];