From 08899893970493ac0300780dcf3536b6bb881f77 Mon Sep 17 00:00:00 2001 From: Doron Behar Date: Fri, 16 Jun 2023 09:15:59 +0300 Subject: [PATCH] tectonic: Don't wrap with biber Frequently, users complain about incompatibilities between biblatex from Tectonic's bundle releases, and Nixpkgs' biber version, compiled from texlive's sources. The issue does not happen within Nixpkgs' texlive, and Nixpkgs' biber, since both of them are updated at the same time, and hence are always compatible with each other. Since Tectonic manages it's tex packages bundle by itself, it's natural that there will be incompatibilities between Tectonic's user's distribution `biber`, and Tectonic's biblatex version from Tectonic's bundle. See upstream's issue: https://github.com/tectonic-typesetting/tectonic/issues/893 For the issue not to arise, we simply hope Tectonic's bundle update itself not long after Nixpkgs' texlive packages are updated. In anycase, `tectonic`'s users in Nixpkgs will be better off dealing with incompatibilities without the need to recompile `tectonic` just to change the `biber` path in wrapper. --- pkgs/tools/typesetting/tectonic/default.nix | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/pkgs/tools/typesetting/tectonic/default.nix b/pkgs/tools/typesetting/tectonic/default.nix index c3818fe71f8b..c2bace466092 100644 --- a/pkgs/tools/typesetting/tectonic/default.nix +++ b/pkgs/tools/typesetting/tectonic/default.nix @@ -8,7 +8,6 @@ , openssl , pkg-config , makeBinaryWrapper -, biber , icu }: @@ -31,12 +30,7 @@ rustPlatform.buildRustPackage rec { buildInputs = [ icu fontconfig harfbuzz openssl ] ++ lib.optionals stdenv.isDarwin (with darwin.apple_sdk.frameworks; [ ApplicationServices Cocoa Foundation ]); - # Tectonic runs biber when it detects it needs to run it, see: - # https://github.com/tectonic-typesetting/tectonic/releases/tag/tectonic%400.7.0 - postInstall = '' - wrapProgram $out/bin/tectonic \ - --prefix PATH : "${lib.getBin biber}/bin" - '' + lib.optionalString stdenv.isLinux '' + postInstall = lib.optionalString stdenv.isLinux '' substituteInPlace dist/appimage/tectonic.desktop \ --replace Exec=tectonic Exec=$out/bin/tectonic install -D dist/appimage/tectonic.desktop -t $out/share/applications/