From 58f7dcd5c8040ad423c5016c662cff100c3a5219 Mon Sep 17 00:00:00 2001 From: Tom Hall Date: Thu, 24 Aug 2023 23:12:59 +0100 Subject: [PATCH 1/3] valhalla: fix build with gcc 12 --- pkgs/development/libraries/valhalla/default.nix | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/pkgs/development/libraries/valhalla/default.nix b/pkgs/development/libraries/valhalla/default.nix index 2d400d73f401..778161622563 100644 --- a/pkgs/development/libraries/valhalla/default.nix +++ b/pkgs/development/libraries/valhalla/default.nix @@ -44,6 +44,11 @@ stdenv.mkDerivation (finalAttrs: { "-DENABLE_BENCHMARKS=OFF" ]; + env.NIX_CFLAGS_COMPILE = toString [ + # Needed for date submodule with GCC 12 https://github.com/HowardHinnant/date/issues/750 + "-Wno-error=stringop-overflow" + ]; + buildInputs = [ boost curl From 900db7c04ef9cc23824cc27f9b533bfd1a45635e Mon Sep 17 00:00:00 2001 From: Tom Hall Date: Fri, 25 Aug 2023 09:59:52 +0100 Subject: [PATCH 2/3] valhalla: Fix build error relating to std::set --- pkgs/development/libraries/valhalla/default.nix | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/pkgs/development/libraries/valhalla/default.nix b/pkgs/development/libraries/valhalla/default.nix index 778161622563..bfd23747db0a 100644 --- a/pkgs/development/libraries/valhalla/default.nix +++ b/pkgs/development/libraries/valhalla/default.nix @@ -1,6 +1,7 @@ { lib , stdenv , fetchFromGitHub +, fetchpatch , cmake , pkg-config , boost @@ -29,6 +30,14 @@ stdenv.mkDerivation (finalAttrs: { fetchSubmodules = true; }; + patches = [ + # Fix build + (fetchpatch { + url = "https://github.com/valhalla/valhalla/commit/e4845b68e8ef8de9eabb359b23bf34c879e21f2b.patch"; + hash = "sha256-xCufmXHGj1JxaMwm64JT9FPY+o0+x4glfJSYLdvHI8U="; + }) + ]; + postPatch = '' substituteInPlace src/bindings/python/CMakeLists.txt \ --replace "\''${Python_SITEARCH}" "${placeholder "out"}/${python3.sitePackages}" From e7fb26513b8489efe94afd63f330dcb1568c1b77 Mon Sep 17 00:00:00 2001 From: Tom Hall Date: Fri, 25 Aug 2023 22:13:59 +0100 Subject: [PATCH 3/3] valhalla, osmscout-server: fix build To avoid linker errors, they need an older version of protobuf, both with abseil-cpp built using the same C++17 standard as valhalla and osmscout-server. --- pkgs/top-level/all-packages.nix | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index e00fbc33de82..f1928ea269f3 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -25474,6 +25474,11 @@ with pkgs; valhalla = callPackage ../development/libraries/valhalla { boost = boost.override { enablePython = true; python = python38; }; + protobuf = protobuf3_21.override { + abseil-cpp = abseil-cpp_202103.override { + cxxStandard = "17"; + }; + }; }; vamp-plugin-sdk = callPackage ../development/libraries/audio/vamp-plugin-sdk { }; @@ -34633,7 +34638,13 @@ with pkgs; osmo-sip-connector = callPackage ../servers/osmocom/osmo-sip-connector { }; - osmscout-server = libsForQt5.callPackage ../applications/misc/osmscout-server { }; + osmscout-server = libsForQt5.callPackage ../applications/misc/osmscout-server { + protobuf = protobuf3_21.override { + abseil-cpp = abseil-cpp_202103.override { + cxxStandard = "17"; + }; + }; + }; palemoon-bin = callPackage ../applications/networking/browsers/palemoon/bin.nix { };