From bef7c7d6f4354acfbbf10f6af298b09eafa961df Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A9ment?= Date: Fri, 20 Mar 2026 18:01:06 -0700 Subject: [PATCH 1/2] python3Packages.pyads: fix build failure --- .../python-modules/pyads/default.nix | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/pkgs/development/python-modules/pyads/default.nix b/pkgs/development/python-modules/pyads/default.nix index 23b0fee8e682..c72d24685f7e 100644 --- a/pkgs/development/python-modules/pyads/default.nix +++ b/pkgs/development/python-modules/pyads/default.nix @@ -1,5 +1,6 @@ { lib, + stdenv, adslib, buildPythonPackage, fetchFromGitHub, @@ -23,13 +24,25 @@ buildPythonPackage rec { buildInputs = [ adslib ]; - patchPhase = '' - substituteInPlace pyads/pyads_ex.py \ - --replace-fail "ctypes.CDLL(adslib)" "ctypes.CDLL(\"${adslib}/lib/adslib.so\")" + postPatch = '' + # Skip compilation of bundled adslib - we provide it as a separate nix package + substituteInPlace setup.py \ + --replace-fail \ + 'return sys.platform.startswith("linux") or sys.platform.startswith("darwin")' \ + 'return False' + + # Load adslib from nix store instead of searching sys.path + substituteInPlace src/pyads/pyads_ex.py \ + --replace-fail \ + 'ctypes.CDLL(adslib_path)' \ + 'ctypes.CDLL("${lib.getLib adslib}/lib/adslib.so")' ''; nativeCheckInputs = [ pytestCheckHook ]; + # Test suite has port reuse races and UDP timing issues on darwin + doCheck = !stdenv.hostPlatform.isDarwin; + pythonImportsCheck = [ "pyads" ]; meta = { From f7c53d4d6d8291ce3fd52b0712714a2296067e39 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A9ment?= Date: Fri, 20 Mar 2026 18:10:26 -0700 Subject: [PATCH 2/2] python3Packages.pyads: 3.5.1 -> 3.5.2 --- pkgs/development/python-modules/pyads/default.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/development/python-modules/pyads/default.nix b/pkgs/development/python-modules/pyads/default.nix index c72d24685f7e..77b659a07b34 100644 --- a/pkgs/development/python-modules/pyads/default.nix +++ b/pkgs/development/python-modules/pyads/default.nix @@ -10,14 +10,14 @@ buildPythonPackage rec { pname = "pyads"; - version = "3.5.1"; + version = "3.5.2"; pyproject = true; src = fetchFromGitHub { owner = "stlehmann"; repo = "pyads"; tag = version; - hash = "sha256-Uh8QS9l0O1UCOM03eZ3Wo8aohgUxSbErRX2/zEUP10k="; + hash = "sha256-mXWLVWzgdWIDpzfBLITLz5olhitkcp/QDrlFj2YMYLw="; }; build-system = [ setuptools ];