From 0792b459eddfe7244b0d6ed59271ccfd974121b7 Mon Sep 17 00:00:00 2001
From: Gaetan Lepage <gaetan@glepage.com>
Date: Sat, 11 Oct 2025 10:12:19 +0000
Subject: [PATCH] quick-lint-js: cleanup

---
 pkgs/by-name/qu/quick-lint-js/package.nix | 52 ++++++++++++-----------
 1 file changed, 28 insertions(+), 24 deletions(-)

diff --git a/pkgs/by-name/qu/quick-lint-js/package.nix b/pkgs/by-name/qu/quick-lint-js/package.nix
index b413e9d7e2ba..fb806943affc 100644
--- a/pkgs/by-name/qu/quick-lint-js/package.nix
+++ b/pkgs/by-name/qu/quick-lint-js/package.nix
@@ -15,10 +15,17 @@ let
   src = fetchFromGitHub {
     owner = "quick-lint";
     repo = "quick-lint-js";
-    rev = version;
+    tag = version;
     hash = "sha256-L2LCRm1Fsg+xRdPc8YmgxDnuXJo92nxs862ewzObZ3I=";
   };
 
+  cmakeFlags = [
+    (lib.cmakeBool "QUICK_LINT_JS_ENABLE_BUILD_TOOLS" true)
+
+    # Temporary workaround for https://github.com/NixOS/nixpkgs/pull/108496#issuecomment-1192083379
+    (lib.cmakeBool "CMAKE_SKIP_BUILD_RPATH" true)
+  ];
+
   quick-lint-js-build-tools = buildPackages.stdenv.mkDerivation {
     pname = "quick-lint-js-build-tools";
     inherit version src;
@@ -27,13 +34,7 @@ let
       cmake
       ninja
     ];
-    doCheck = false;
-
-    cmakeFlags = [
-      "-DQUICK_LINT_JS_ENABLE_BUILD_TOOLS=ON"
-      # Temporary workaround for https://github.com/NixOS/nixpkgs/pull/108496#issuecomment-1192083379
-      "-DCMAKE_SKIP_BUILD_RPATH=ON"
-    ];
+    inherit cmakeFlags;
     ninjaFlags = "quick-lint-js-build-tools";
 
     installPhase = ''
@@ -41,9 +42,11 @@ let
       cmake --install . --component build-tools
       runHook postInstall
     '';
+
+    doCheck = false;
   };
 in
-stdenv.mkDerivation {
+stdenv.mkDerivation (finalAttrs: {
   pname = "quick-lint-js";
   inherit version src;
 
@@ -51,27 +54,28 @@ stdenv.mkDerivation {
     cmake
     ninja
   ];
+
+  inherit cmakeFlags;
+
   doCheck = true;
 
-  cmakeFlags = [
-    "-DQUICK_LINT_JS_USE_BUILD_TOOLS=${quick-lint-js-build-tools}/bin"
-    # Temporary workaround for https://github.com/NixOS/nixpkgs/pull/108496#issuecomment-1192083379
-    "-DCMAKE_SKIP_BUILD_RPATH=ON"
-  ];
+  passthru = {
+    # Expose quick-lint-js-build-tools to nix repl as quick-lint-js.build-tools.
+    build-tools = quick-lint-js-build-tools;
 
-  passthru.tests = {
-    version = testers.testVersion { package = quick-lint-js; };
+    tests = {
+      version = testers.testVersion { package = quick-lint-js; };
+    };
   };
 
-  meta = with lib; {
+  meta = {
     description = "Find bugs in Javascript programs";
     mainProgram = "quick-lint-js";
     homepage = "https://quick-lint-js.com";
-    license = licenses.gpl3Plus;
-    maintainers = with maintainers; [ ratsclub ];
-    platforms = platforms.all;
+    downloadPage = "https://github.com/quick-lint/quick-lint-js";
+    changelog = "https://github.com/quick-lint/quick-lint-js/releases/tag/${finalAttrs.src.tag}";
+    license = lib.licenses.gpl3Plus;
+    maintainers = with lib.maintainers; [ ratsclub ];
+    platforms = lib.platforms.all;
   };
-
-  # Expose quick-lint-js-build-tools to nix repl as quick-lint-js.build-tools.
-  passthru.build-tools = quick-lint-js-build-tools;
-}
+})