From a35e1694a8970f82ff4fcbd9142cb4960350c0e0 Mon Sep 17 00:00:00 2001 From: Adam Joseph Date: Sat, 1 Jul 2023 16:29:13 -0700 Subject: [PATCH 1/2] gcc: if isM68k, look for libgcc_s.so.2 (instead of .so.1) Closes #243613 --- pkgs/development/compilers/gcc/common/libgcc.nix | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/pkgs/development/compilers/gcc/common/libgcc.nix b/pkgs/development/compilers/gcc/common/libgcc.nix index 626b14835c9a..b14d111e361f 100644 --- a/pkgs/development/compilers/gcc/common/libgcc.nix +++ b/pkgs/development/compilers/gcc/common/libgcc.nix @@ -46,6 +46,13 @@ lib.optional (lib.versionAtLeast version "11.0") enableShared ; + # For some reason libgcc_s.so has major-version "2" on m68k but + # "1" everywhere else. Might be worth changing this to "*". + libgcc_s-version-major = + if targetPlatform.isM68k + then "2" + else "1"; + in (pkg: pkg.overrideAttrs (previousAttrs: lib.optionalAttrs ((!langC) || langJit || enableLibGccOutput) { outputs = previousAttrs.outputs ++ lib.optionals enableLibGccOutput [ "libgcc" ]; @@ -75,9 +82,9 @@ in # move libgcc from lib to its own output (libgcc) mkdir -p $libgcc/lib mv $lib/${targetPlatformSlash}lib/libgcc_s.so $libgcc/lib/ - mv $lib/${targetPlatformSlash}lib/libgcc_s.so.1 $libgcc/lib/ + mv $lib/${targetPlatformSlash}lib/libgcc_s.so.${libgcc_s-version-major} $libgcc/lib/ ln -s $libgcc/lib/libgcc_s.so $lib/${targetPlatformSlash}lib/ - ln -s $libgcc/lib/libgcc_s.so.1 $lib/${targetPlatformSlash}lib/ + ln -s $libgcc/lib/libgcc_s.so.${libgcc_s-version-major} $lib/${targetPlatformSlash}lib/ '' # # Nixpkgs ordinarily turns dynamic linking into pseudo-static linking: @@ -134,7 +141,7 @@ in # another eliminates the ability to make these queries. # + '' - patchelf --set-rpath "" $libgcc/lib/libgcc_s.so.1 + patchelf --set-rpath "" $libgcc/lib/libgcc_s.so.${libgcc_s-version-major} ''); })))) From 895c24349c7e715bca41d6718e10fdd782cc0dcc Mon Sep 17 00:00:00 2001 From: Adam Joseph Date: Sat, 1 Jul 2023 16:34:00 -0700 Subject: [PATCH 2/2] test.cross.sanity: add pkgs.pkgsCross.m68k.stdenv --- pkgs/test/cross/default.nix | 1 + 1 file changed, 1 insertion(+) diff --git a/pkgs/test/cross/default.nix b/pkgs/test/cross/default.nix index f31d6aefbdda..ad2689d5d217 100644 --- a/pkgs/test/cross/default.nix +++ b/pkgs/test/cross/default.nix @@ -134,6 +134,7 @@ let pkgs.pkgsLLVM.stdenv pkgs.pkgsStatic.bash pkgs.pkgsCross.arm-embedded.stdenv + pkgs.pkgsCross.m68k.stdenv pkgs.pkgsCross.aarch64-multiplatform.pkgsBuildTarget.gcc #pkgs.pkgsCross.powernv.pkgsBuildTarget.gcc pkgs.pkgsCross.mips64el-linux-gnuabi64.stdenv