From 51e6b12df39f1733f4ff35603250c8e77d7d4a81 Mon Sep 17 00:00:00 2001
From: griffi-gh <prasol258@gmail.com>
Date: Tue, 18 Feb 2025 13:18:38 +0100
Subject: [PATCH] luakit: 2.3.3 -> 2.4.0, add maintainer

---
 nixos/doc/manual/release-notes/rl-2505.section.md |  2 ++
 pkgs/by-name/lu/luakit/package.nix                | 14 ++++++++------
 2 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/nixos/doc/manual/release-notes/rl-2505.section.md b/nixos/doc/manual/release-notes/rl-2505.section.md
index f69de1860a60..4a296b1891dd 100644
--- a/nixos/doc/manual/release-notes/rl-2505.section.md
+++ b/nixos/doc/manual/release-notes/rl-2505.section.md
@@ -429,6 +429,8 @@
 
 - `services.homepage-dashboard` now requires the `allowedHosts` option to be set in accordance with the [documentation](https://gethomepage.dev/installation/#homepage_allowed_hosts).
 
+- `luakit` has been updated to 2.4.0. If you use any website which uses IndexedDB or local storage and wish to retain the saved information, [some manual intervention may be required](https://luakit.github.io/news/luakit-2.4.0.html)
+
 - `services.netbird.tunnels` was renamed to [`services.netbird.clients`](#opt-services.netbird.clients),
   hardened (using dedicated less-privileged users) and significantly extended.
 
diff --git a/pkgs/by-name/lu/luakit/package.nix b/pkgs/by-name/lu/luakit/package.nix
index 7222f712b1dd..49b42cfd826a 100644
--- a/pkgs/by-name/lu/luakit/package.nix
+++ b/pkgs/by-name/lu/luakit/package.nix
@@ -10,22 +10,21 @@
   pkg-config,
   sqlite,
   stdenv,
-  webkitgtk_4_0,
+  webkitgtk_4_1,
   wrapGAppsHook3,
 }:
-
 let
   inherit (luajitPackages) luafilesystem;
 in
 stdenv.mkDerivation (finalAttrs: {
   pname = "luakit";
-  version = "2.3.3";
+  version = "2.4.0";
 
   src = fetchFromGitHub {
     owner = "luakit";
     repo = "luakit";
     rev = finalAttrs.version;
-    hash = "sha256-DtoixcLq+ddbacTAo+Qq6q4k1i6thirACw1zqUeOxXo=";
+    hash = "sha256-6OPcGwWQyP+xWVKGjwEfE8Xnf1gcwwbO+FbvA1x0c8M=";
   };
 
   nativeBuildInputs = [
@@ -41,7 +40,7 @@ stdenv.mkDerivation (finalAttrs: {
       gtk3
       luafilesystem
       sqlite
-      webkitgtk_4_0
+      webkitgtk_4_1
     ]
     ++ (with gst_all_1; [
       gst-libav
@@ -65,6 +64,7 @@ stdenv.mkDerivation (finalAttrs: {
   makeFlags = [
     "DEVELOPMENT_PATHS=0"
     "USE_LUAJIT=1"
+    "LUA_BIN_NAME=luajit"
     "INSTALLDIR=${placeholder "out"}"
     "PREFIX=${placeholder "out"}"
     "USE_GTK3=1"
@@ -95,7 +95,9 @@ stdenv.mkDerivation (finalAttrs: {
     '';
     license = lib.licenses.gpl3Only;
     mainProgram = "luakit";
-    maintainers = with lib.maintainers; [ ];
+    maintainers = with lib.maintainers; [
+      griffi-gh
+    ];
     platforms = lib.platforms.unix;
   };
 })