From d44f6f2eb3b35748b4015aff0a363f96f1148b96 Mon Sep 17 00:00:00 2001 From: Nick Cao Date: Wed, 31 Jan 2024 23:40:34 -0500 Subject: [PATCH 1/2] nbd: add patch to fix reading port setting from nbdtab --- pkgs/tools/networking/nbd/default.nix | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/pkgs/tools/networking/nbd/default.nix b/pkgs/tools/networking/nbd/default.nix index c7cb5632dfe4..8e3d6768b668 100644 --- a/pkgs/tools/networking/nbd/default.nix +++ b/pkgs/tools/networking/nbd/default.nix @@ -1,6 +1,7 @@ { lib , stdenv , fetchurl +, fetchpatch , pkg-config , glib , which @@ -20,6 +21,15 @@ stdenv.mkDerivation rec { hash = "sha256-9cj9D8tXsckmWU0OV/NWQy7ghni+8dQNCI8IMPDL3Qo="; }; + patches = [ + # fix port setting from nbdtab + # https://github.com/NetworkBlockDevice/nbd/pull/154 + (fetchpatch { + url = "https://github.com/NetworkBlockDevice/nbd/commit/915444bc0b8a931d32dfb755542f4bd1d37f1449.patch"; + hash = "sha256-6z+c2cXhY92WPDqRO6AJ5BBf1N38yTgOE1foduIr5Dg="; + }) + ]; + nativeBuildInputs = [ pkg-config which From 479c0b5f6b3d106067e96ec72367e738f2c925b2 Mon Sep 17 00:00:00 2001 From: Nick Cao Date: Thu, 1 Feb 2024 10:02:30 -0500 Subject: [PATCH 2/2] nbd: fix build with clang --- pkgs/tools/networking/nbd/default.nix | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pkgs/tools/networking/nbd/default.nix b/pkgs/tools/networking/nbd/default.nix index 8e3d6768b668..ebef277feb21 100644 --- a/pkgs/tools/networking/nbd/default.nix +++ b/pkgs/tools/networking/nbd/default.nix @@ -48,6 +48,9 @@ stdenv.mkDerivation rec { "--sysconfdir=/etc" ]; + # ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] + env.NIX_CFLAGS_COMPILE = lib.optionalString stdenv.cc.isClang "-Wno-error=implicit-function-declaration"; + doCheck = !stdenv.isDarwin; passthru.tests = {