From 044abb14a1ed1294026481cc5d032956f7c41854 Mon Sep 17 00:00:00 2001 From: Guilhem Saurel Date: Fri, 24 Oct 2025 00:06:00 +0200 Subject: [PATCH] lib3mf: fix header install MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Somehow this was working before, but around 2025-10-23, something changed on master, and nixpkgs-review would stop working on https://github.com/NixOS/nixpkgs/pull/445078: ``` $ nix build -L github:NixOS/nixpkgs/pull/445078/head#lib3mf.dev $ eza result-dev/include/  lib3mf/ $ nix build -L github:NixOS/nixpkgs/pull/445078/merge#lib3mf.dev $ eza result-dev/include/ "result-dev/include/": No such file or directory (os error 2) ``` The headers are now installed in the build tree: ``` -- Installing: /nix/store/i7qd0hcky65i557fqjl5qq3xrp30hwhz-lib3mf-2.4.1/lib/lib3mf.so.2 -- Installing: /nix/store/i7qd0hcky65i557fqjl5qq3xrp30hwhz-lib3mf-2.4.1/lib/lib3mf.so -- Installing: /build/source/build/include/lib3mf/Bindings -- Installing: /build/source/build/include/lib3mf/Bindings/NodeJS -- Installing: /build/source/build/include/lib3mf/Bindings/NodeJS/lib3mf_nodeaddon.cc -- Installing: /build/source/build/include/lib3mf/Bindings/NodeJS/lib3mf_nodewrapper.cc ``` Maybe CMake 4.1.1 -> 4.1.2 changed something. --- pkgs/by-name/li/lib3mf/package.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/by-name/li/lib3mf/package.nix b/pkgs/by-name/li/lib3mf/package.nix index 289fcaf48d75..6424ac5b2c9c 100644 --- a/pkgs/by-name/li/lib3mf/package.nix +++ b/pkgs/by-name/li/lib3mf/package.nix @@ -59,7 +59,7 @@ stdenv.mkDerivation (finalAttrs: { ]; cmakeFlags = [ - "-DCMAKE_INSTALL_INCLUDEDIR=include/lib3mf" + "-DCMAKE_INSTALL_INCLUDEDIR=${placeholder "dev"}/include/lib3mf" "-DUSE_INCLUDED_ZLIB=OFF" "-DUSE_INCLUDED_LIBZIP=OFF" "-DUSE_INCLUDED_GTEST=OFF"