From 0416992bba13dc2261a1bc9b3df3f29b2d97c5de Mon Sep 17 00:00:00 2001 From: Sigmanificient Date: Fri, 17 Oct 2025 16:56:57 +0200 Subject: [PATCH] pianobooster: use patch to fix cmake build failure --- .../bump-cmake-minimum-required-version.patch | 33 +++++++++++++++++++ pkgs/by-name/pi/pianobooster/package.nix | 7 +++- 2 files changed, 39 insertions(+), 1 deletion(-) create mode 100644 pkgs/by-name/pi/pianobooster/bump-cmake-minimum-required-version.patch diff --git a/pkgs/by-name/pi/pianobooster/bump-cmake-minimum-required-version.patch b/pkgs/by-name/pi/pianobooster/bump-cmake-minimum-required-version.patch new file mode 100644 index 000000000000..5b02d1b8ac95 --- /dev/null +++ b/pkgs/by-name/pi/pianobooster/bump-cmake-minimum-required-version.patch @@ -0,0 +1,33 @@ +From aba8b1570051e17e9568cfcc2a2b0ed316e90075 Mon Sep 17 00:00:00 2001 +From: Adrian Bunk +Date: Sat, 11 Oct 2025 15:39:08 +0300 +Subject: [PATCH] Bump cmake_minimum_required to support CMake 4 + +--- + CMakeLists.txt | 2 +- + src/CMakeLists.txt | 2 +- + 2 files changed, 2 insertions(+), 2 deletions(-) + +diff --git a/CMakeLists.txt b/CMakeLists.txt +index 8432a843..c4bbe56e 100644 +--- a/CMakeLists.txt ++++ b/CMakeLists.txt +@@ -1,4 +1,4 @@ +-cmake_minimum_required(VERSION 2.4) ++cmake_minimum_required(VERSION 3.5) + if(COMMAND cmake_policy) + cmake_policy(SET CMP0003 NEW) + endif(COMMAND cmake_policy) +diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt +index 02867c8f..23bc9eff 100644 +--- a/src/CMakeLists.txt ++++ b/src/CMakeLists.txt +@@ -10,7 +10,7 @@ else() + option(USE_BUNDLED_RTMIDI "Build with bundled rtmidi" ON) + endif() + +-cmake_minimum_required(VERSION 2.4) ++cmake_minimum_required(VERSION 3.5) + if(COMMAND cmake_policy) + cmake_policy(SET CMP0003 NEW) + endif(COMMAND cmake_policy) diff --git a/pkgs/by-name/pi/pianobooster/package.nix b/pkgs/by-name/pi/pianobooster/package.nix index 955ad3953a16..178c2d1466c6 100644 --- a/pkgs/by-name/pi/pianobooster/package.nix +++ b/pkgs/by-name/pi/pianobooster/package.nix @@ -26,6 +26,12 @@ stdenv.mkDerivation (finalAttrs: { hash = "sha256-1WOlAm/HXSL6QK0Kd1mnFEZxxpMseTG+6WzgMNWt+RA="; }; + patches = [ + # Bump cmake_minimum_required to support CMake 4 + # https://github.com/pianobooster/PianoBooster/pull/349 + ./bump-cmake-minimum-required-version.patch + ]; + postPatch = '' substituteInPlace src/Settings.cpp src/GuiMidiSetupDialog.cpp \ --replace "/usr/share/soundfonts" "${soundfont-fluid}/share/soundfonts" \ @@ -52,7 +58,6 @@ stdenv.mkDerivation (finalAttrs: { ]; cmakeFlags = [ - "-DCMAKE_POLICY_VERSION_MINIMUM=3.5" "-DOpenGL_GL_PREFERENCE=GLVND" "-DUSE_JACK=ON" ];