From 03675716cf607867764e30c3a643dc009c762655 Mon Sep 17 00:00:00 2001 From: Emily Date: Sun, 24 Nov 2024 04:06:32 +0000 Subject: [PATCH] litecoin{,d}: drop MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Our current version is from March 2023; there was a release with a critical security fix in March of this year, and another one with more security fixes two weeks ago. The listed maintainer has been inactive in Nixpkgs for years and it seems nobody else is stepping up to keep this package secure and updated. Let’s drop it until that changes. --- .../blockchains/litecoin/default.nix | 81 ------------------- pkgs/top-level/aliases.nix | 2 + pkgs/top-level/all-packages.nix | 6 -- 3 files changed, 2 insertions(+), 87 deletions(-) delete mode 100644 pkgs/applications/blockchains/litecoin/default.nix diff --git a/pkgs/applications/blockchains/litecoin/default.nix b/pkgs/applications/blockchains/litecoin/default.nix deleted file mode 100644 index 0f923fb8f6b8..000000000000 --- a/pkgs/applications/blockchains/litecoin/default.nix +++ /dev/null @@ -1,81 +0,0 @@ -{ lib, stdenv, mkDerivation, fetchFromGitHub, fetchpatch, fetchpatch2 -, pkg-config, autoreconfHook -, openssl, db48, boost, zlib, miniupnpc -, glib, protobuf, util-linux, qrencode -, AppKit -, withGui ? true, libevent -, qtbase, qttools -, zeromq -, fmt -}: - -mkDerivation rec { - pname = "litecoin" + lib.optionalString (!withGui) "d"; - version = "0.21.2.2"; - - src = fetchFromGitHub { - owner = "litecoin-project"; - repo = "litecoin"; - rev = "v${version}"; - sha256 = "sha256-TuDc47TZOEQA5Lr4DQkEhnO/Szp9h71xPjaBL3jFWuM="; - }; - - patches = [ - (fetchpatch { - name = "boost1770.patch"; - url = "https://aur.archlinux.org/cgit/aur.git/plain/boost1770.patch?h=litecoin-qt&id=dc75ad854af123f375b5b683be64aa14573170d7"; - hash = "sha256-PTkYQRA8n5a9yR2AvpzH5natsXT2W6Xjo0ONCPJx78k="; - }) - - # Fix gcc-13 build by adding missing headers: - # https://github.com/litecoin-project/litecoin/pull/929 - (fetchpatch { - name = "gcc-13.patch"; - url = "https://github.com/litecoin-project/litecoin/commit/6d1adb19aa79a8e8e140582759515bbd76816aa0.patch"; - hash = "sha256-1y4Iz2plMw5HMAjl9x50QQpYrYaUd2WKrrAcUnQmlBY="; - }) - - # net: add compatibility for miniupnpc 2.2.8 - # https://github.com/litecoin-project/litecoin/pull/971 - (fetchpatch2 { - url = "https://github.com/litecoin-project/litecoin/commit/5dddffa3e1bbcc7a3e6963b4860ba2d675ca847b.patch?full_index=1"; - hash = "sha256-F5GcL1RM91l04WrS3qYlV5zEcwyXrcRdmLLCqu1Hop0="; - }) - ]; - - nativeBuildInputs = [ pkg-config autoreconfHook ]; - buildInputs = [ openssl db48 boost zlib zeromq fmt - miniupnpc glib protobuf util-linux libevent ] - ++ lib.optionals stdenv.hostPlatform.isDarwin [ AppKit ] - ++ lib.optionals withGui [ qtbase qttools qrencode ]; - - configureFlags = [ "--with-boost-libdir=${boost.out}/lib" ] - ++ lib.optionals withGui [ - "--with-gui=qt5" - "--with-qt-bindir=${qtbase.dev}/bin:${qttools.dev}/bin" ]; - - enableParallelBuilding = true; - - doCheck = true; - checkPhase = '' - ./src/test/test_litecoin - ''; - - meta = with lib; { - broken = (stdenv.hostPlatform.isLinux && stdenv.hostPlatform.isAarch64) || stdenv.hostPlatform.isDarwin; - description = "Lite version of Bitcoin using scrypt as a proof-of-work algorithm"; - longDescription= '' - Litecoin is a peer-to-peer Internet currency that enables instant payments - to anyone in the world. It is based on the Bitcoin protocol but differs - from Bitcoin in that it can be efficiently mined with consumer-grade hardware. - Litecoin provides faster transaction confirmations (2.5 minutes on average) - and uses a memory-hard, scrypt-based mining proof-of-work algorithm to target - the regular computers and GPUs most people already have. - The Litecoin network is scheduled to produce 84 million currency units. - ''; - homepage = "https://litecoin.org/"; - platforms = platforms.unix; - license = licenses.mit; - maintainers = with maintainers; [ offline ]; - }; -} diff --git a/pkgs/top-level/aliases.nix b/pkgs/top-level/aliases.nix index 4efab55ea533..24707fc05a9b 100644 --- a/pkgs/top-level/aliases.nix +++ b/pkgs/top-level/aliases.nix @@ -659,6 +659,8 @@ mapAliases { lispPackages_new = throw "Lisp packages have been redesigned. See 'lisp-modules' in the nixpkgs manual."; # Added 2024-05-07 lispPackages = throw "Lisp packages have been redesigned. See 'lisp-modules' in the nixpkgs manual."; # Added 2024-05-07 lispPackagesFor = throw "Lisp packages have been redesigned. See 'lisp-modules' in the nixpkgs manual."; # Added 2024-05-07 + litecoin = throw "litecoin has been removed as nobody was maintaining it and the packaged version had known vulnerabilities"; # Added 2024-11-24 + litecoind = throw "litecoind has been removed as nobody was maintaining it and the packaged version had known vulnerabilities"; # Added 2024-11-24 Literate = literate; # Added 2024-06-12 llama = walk; # Added 2023-01-23 diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index 5fc418283c33..cb92496efd6a 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -16626,12 +16626,6 @@ with pkgs; ledger-agent = with python3Packages; toPythonApplication ledger-agent; - litecoin = libsForQt5.callPackage ../applications/blockchains/litecoin { - inherit (darwin.apple_sdk.frameworks) AppKit; - boost = pkgs.boost177; - }; - litecoind = litecoin.override { withGui = false; }; - monero-cli = callPackage ../applications/blockchains/monero-cli { inherit (darwin.apple_sdk.frameworks) CoreData IOKit; };