From fada67f065c60c84c9033b09562cdefecb665a7a Mon Sep 17 00:00:00 2001 From: "R. Ryantm" Date: Sun, 25 Dec 2022 12:05:34 +0000 Subject: [PATCH 1/3] python310Packages.autofaiss: 2.15.3 -> 2.15.4 --- pkgs/development/python-modules/autofaiss/default.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/development/python-modules/autofaiss/default.nix b/pkgs/development/python-modules/autofaiss/default.nix index 443a086c5f82..a8ee4a298be8 100644 --- a/pkgs/development/python-modules/autofaiss/default.nix +++ b/pkgs/development/python-modules/autofaiss/default.nix @@ -13,13 +13,13 @@ buildPythonPackage rec { pname = "autofaiss"; - version = "2.15.3"; + version = "2.15.4"; src = fetchFromGitHub { owner = "criteo"; repo = pname; rev = "refs/tags/${version}"; - hash = "sha256-RJOOUMI4w1YPEjDKi0YkqTXU01AbVoPn2+Id6kdC5pA="; + hash = "sha256-OnDHwJxJcXx3DGxrkk2D2Ljs4CqPoYx7avdo9C8sDrU="; }; nativeBuildInputs = [ pythonRelaxDepsHook ]; From bf5ad98cce2535f09d8b4d7bd91600d1941986dc Mon Sep 17 00:00:00 2001 From: Fabian Affolter Date: Sun, 25 Dec 2022 15:15:29 +0100 Subject: [PATCH 2/3] python310Packages.autofaiss: add changelog to meta --- .../python-modules/autofaiss/default.nix | 22 ++++++++++++++++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/pkgs/development/python-modules/autofaiss/default.nix b/pkgs/development/python-modules/autofaiss/default.nix index a8ee4a298be8..4d80fdcacfc9 100644 --- a/pkgs/development/python-modules/autofaiss/default.nix +++ b/pkgs/development/python-modules/autofaiss/default.nix @@ -9,11 +9,15 @@ , pyarrow , pytestCheckHook , pythonRelaxDepsHook +, pythonOlder }: buildPythonPackage rec { pname = "autofaiss"; version = "2.15.4"; + format = "setuptools"; + + disabled = pythonOlder "3.6"; src = fetchFromGitHub { owner = "criteo"; @@ -22,7 +26,9 @@ buildPythonPackage rec { hash = "sha256-OnDHwJxJcXx3DGxrkk2D2Ljs4CqPoYx7avdo9C8sDrU="; }; - nativeBuildInputs = [ pythonRelaxDepsHook ]; + nativeBuildInputs = [ + pythonRelaxDepsHook + ]; pythonRemoveDeps = [ # The `dataclasses` packages is a python2-only backport, unnecessary in @@ -38,9 +44,18 @@ buildPythonPackage rec { "pyarrow" ]; - propagatedBuildInputs = [ embedding-reader fsspec numpy faiss fire pyarrow ]; + propagatedBuildInputs = [ + embedding-reader + fsspec + numpy + faiss + fire + pyarrow + ]; - checkInputs = [ pytestCheckHook ]; + checkInputs = [ + pytestCheckHook + ]; disabledTests = [ # Attempts to spin up a Spark cluster and talk to it which doesn't work in @@ -54,6 +69,7 @@ buildPythonPackage rec { meta = with lib; { description = "Automatically create Faiss knn indices with the most optimal similarity search parameters"; homepage = "https://github.com/criteo/autofaiss"; + changelog = "https://github.com/criteo/autofaiss/blob/${version}/CHANGELOG.md"; license = licenses.asl20; maintainers = with maintainers; [ samuela ]; }; From 5c39d7268ca4b706c97ee23b6ff0d15b0d0176e7 Mon Sep 17 00:00:00 2001 From: Samuel Ainsworth Date: Sun, 25 Dec 2022 23:33:13 -0500 Subject: [PATCH 3/3] python3Packages.autofaiss: relax fire dependency --- pkgs/development/python-modules/autofaiss/default.nix | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pkgs/development/python-modules/autofaiss/default.nix b/pkgs/development/python-modules/autofaiss/default.nix index 4d80fdcacfc9..6b8e29a98e70 100644 --- a/pkgs/development/python-modules/autofaiss/default.nix +++ b/pkgs/development/python-modules/autofaiss/default.nix @@ -39,6 +39,9 @@ buildPythonPackage rec { ]; pythonRelaxDeps = [ + # As of v2.15.4, autofaiss asks for fire<0.5 but we have fire v0.5.0 in + # nixpkgs at the time of writing (2022-12-25). + "fire" # As of v2.15.3, autofaiss asks for pyarrow<8 but we have pyarrow v9.0.0 in # nixpkgs at the time of writing (2022-12-15). "pyarrow"