From 7f347f109a946c38679c6933e006622f3bfdb0aa Mon Sep 17 00:00:00 2001 From: Anderson Torres Date: Fri, 1 Mar 2024 09:22:59 -0300 Subject: [PATCH 1/3] wlogout: migrate to by-name --- .../wlogout/default.nix => by-name/wl/wlogout/package.nix} | 0 pkgs/top-level/all-packages.nix | 2 -- 2 files changed, 2 deletions(-) rename pkgs/{tools/wayland/wlogout/default.nix => by-name/wl/wlogout/package.nix} (100%) diff --git a/pkgs/tools/wayland/wlogout/default.nix b/pkgs/by-name/wl/wlogout/package.nix similarity index 100% rename from pkgs/tools/wayland/wlogout/default.nix rename to pkgs/by-name/wl/wlogout/package.nix diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index 667e4a9c1a88..aba6949849c6 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -4829,8 +4829,6 @@ with pkgs; wleave = callPackage ../tools/wayland/wleave { }; - wlogout = callPackage ../tools/wayland/wlogout { }; - wlopm = callPackage ../tools/wayland/wlopm { }; wlprop = callPackage ../tools/wayland/wlprop { }; From 1b2dfbb8c6bf9b89ce8e050d98c8e072cf44528f Mon Sep 17 00:00:00 2001 From: Anderson Torres Date: Fri, 1 Mar 2024 09:41:58 -0300 Subject: [PATCH 2/3] wlogout: refactor - finalAttrs design pattern to get rid of rec - split outputs - add passthru.updateScript - get rid of nested with - set meta.changelog --- pkgs/by-name/wl/wlogout/package.nix | 65 ++++++++++++++++++----------- 1 file changed, 41 insertions(+), 24 deletions(-) diff --git a/pkgs/by-name/wl/wlogout/package.nix b/pkgs/by-name/wl/wlogout/package.nix index 96cabcc38e87..47145d29b80b 100644 --- a/pkgs/by-name/wl/wlogout/package.nix +++ b/pkgs/by-name/wl/wlogout/package.nix @@ -1,15 +1,16 @@ { lib -, stdenv , fetchFromGitHub -, pkg-config -, meson -, ninja -, scdoc +, gitUpdater +, gtk-layer-shell , gtk3 , libxkbcommon +, meson +, ninja +, pkg-config +, scdoc +, stdenv , wayland , wayland-protocols -, gtk-layer-shell # gtk-layer-shell fails to cross-compile due to a hard dependency # on gobject-introspection. # Disable it when cross-compiling since it's an optional dependency. @@ -17,20 +18,30 @@ , withGtkLayerShell ? (stdenv.buildPlatform == stdenv.hostPlatform) }: -stdenv.mkDerivation rec { +stdenv.mkDerivation (finalAttrs: { pname = "wlogout"; version = "1.2"; src = fetchFromGitHub { owner = "ArtsyMacaw"; repo = "wlogout"; - rev = version; + rev = finalAttrs.version; hash = "sha256-xeTO8MBUrvcVA7WTRY7OhaVGInijuvXsVYEax8JmMZ0="; }; - strictDeps = true; - depsBuildBuild = [ pkg-config ]; - nativeBuildInputs = [ pkg-config meson ninja scdoc ]; + outputs = [ "out" "man" ]; + + depsBuildBuild = [ + pkg-config + ]; + + nativeBuildInputs = [ + meson + ninja + pkg-config + scdoc + ]; + buildInputs = [ gtk3 libxkbcommon @@ -40,26 +51,32 @@ stdenv.mkDerivation rec { gtk-layer-shell ]; - postPatch = '' - substituteInPlace style.css \ - --replace "/usr/share/wlogout" "$out/share/${pname}" - - substituteInPlace main.c \ - --replace "/etc/wlogout" "$out/etc/${pname}" - ''; + strictDeps = true; mesonFlags = [ "--datadir=${placeholder "out"}/share" "--sysconfdir=${placeholder "out"}/etc" ]; - meta = with lib; { + postPatch = '' + substituteInPlace style.css \ + --replace "/usr/share/wlogout" "$out/share/wlogout" + + substituteInPlace main.c \ + --replace "/etc/wlogout" "$out/etc/wlogout" + ''; + + passthru = { + updateScript = gitUpdater { }; + }; + + meta = { homepage = "https://github.com/ArtsyMacaw/wlogout"; description = "A wayland based logout menu"; - license = licenses.mit; - maintainers = with maintainers; [ AndersonTorres ]; - platforms = platforms.linux; + changelog = "https://github.com/ArtsyMacaw/wlogout/releases/tag/${finalAttrs.src.rev}"; + license = with lib.licenses; [ mit ]; mainProgram = "wlogout"; + maintainers = with lib.maintainers; [ AndersonTorres ]; + inherit (wayland.meta) platforms; }; -} -# TODO: shell completions +}) From e0209ab56b6251a71bb705950f1efc7994a794ec Mon Sep 17 00:00:00 2001 From: rewine Date: Fri, 1 Mar 2024 09:49:41 -0300 Subject: [PATCH 3/3] wlogout: 1.2 -> 1.2.1 --- pkgs/by-name/wl/wlogout/package.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/by-name/wl/wlogout/package.nix b/pkgs/by-name/wl/wlogout/package.nix index 47145d29b80b..0107dbad89ba 100644 --- a/pkgs/by-name/wl/wlogout/package.nix +++ b/pkgs/by-name/wl/wlogout/package.nix @@ -20,13 +20,13 @@ stdenv.mkDerivation (finalAttrs: { pname = "wlogout"; - version = "1.2"; + version = "1.2.1"; src = fetchFromGitHub { owner = "ArtsyMacaw"; repo = "wlogout"; rev = finalAttrs.version; - hash = "sha256-xeTO8MBUrvcVA7WTRY7OhaVGInijuvXsVYEax8JmMZ0="; + hash = "sha256-n8r+E6GXXjyDYBTOMiv5musamaUFSpRTM2qHgb047og="; }; outputs = [ "out" "man" ];