From 019bbf203afc6b20ae3422ea15186dfffabc6058 Mon Sep 17 00:00:00 2001
From: Marcin Serwin <marcin@serwin.dev>
Date: Wed, 5 Mar 2025 22:36:30 +0100
Subject: [PATCH] gst_all_1.gst-plugins-bad: disable DirectFB

DirectFB had no point release for 11 years now and is probably unused by
the majority of users, yet it's a transitive dependency of many packages
due to being used in gst-plugins-bad. This plugin has been disabled in
Arch for 5 years now
<https://gitlab.archlinux.org/archlinux/packaging/packages/gst-plugins-bad/-/commit/899fb518af27d82a9b07a2b341cd55edba1575b9#9b9baac1eb9b72790eef5540a1685306fc43fd6c_59_40>
and it will be disabled in the next Debian release:
<https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1083040>
so this change should be fairly safe.
---
 pkgs/development/libraries/gstreamer/bad/default.nix | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/pkgs/development/libraries/gstreamer/bad/default.nix b/pkgs/development/libraries/gstreamer/bad/default.nix
index 7e756b976b21..d573d2325fba 100644
--- a/pkgs/development/libraries/gstreamer/bad/default.nix
+++ b/pkgs/development/libraries/gstreamer/bad/default.nix
@@ -111,7 +111,7 @@
 , microdnsSupport ? false
 # Checks meson.is_cross_build(), so even canExecute isn't enough.
 , enableDocumentation ? stdenv.hostPlatform == stdenv.buildPlatform, hotdoc
-, guiSupport ? true, directfb
+, guiSupport ? true
 }:
 
 stdenv.mkDerivation rec {
@@ -253,8 +253,6 @@ stdenv.mkDerivation rec {
     libGLU
   ] ++ lib.optionals guiSupport [
     gtk3
-  ] ++ lib.optionals (stdenv.hostPlatform.isLinux && guiSupport) [
-    directfb
   ] ++ lib.optionals stdenv.hostPlatform.isDarwin [
     # For unknown reasons the order is important, e.g. if
     # VideoToolbox is last, we get:
@@ -313,14 +311,13 @@ stdenv.mkDerivation rec {
     "-Dbluez=${if bluezSupport then "enabled" else "disabled"}"
     (lib.mesonEnable "openh264" openh264Support)
     (lib.mesonEnable "doc" enableDocumentation)
+    (lib.mesonEnable "directfb" false)
   ]
   ++ lib.optionals (!stdenv.hostPlatform.isLinux) [
     "-Ddoc=disabled" # needs gstcuda to be enabled which is Linux-only
     "-Dnvcodec=disabled" # Linux-only
   ] ++ lib.optionals (!stdenv.hostPlatform.isLinux || !gst-plugins-base.waylandEnabled) [
     "-Dva=disabled" # see comment on `libva` in `buildInputs`
-  ] ++ lib.optionals (!stdenv.hostPlatform.isLinux || !guiSupport) [
-    "-Ddirectfb=disabled"
   ] ++ lib.optionals stdenv.hostPlatform.isDarwin [
     "-Daja=disabled"
     "-Dchromaprint=disabled"