From c3da3ce7390bbd7933d50090e668439baf050b2e Mon Sep 17 00:00:00 2001 From: Nikolay Korotkiy Date: Thu, 18 Nov 2021 23:27:51 +0300 Subject: [PATCH 1/4] kristall: fix build on darwin --- .../networking/browsers/kristall/default.nix | 39 ++++++++++++------- 1 file changed, 26 insertions(+), 13 deletions(-) diff --git a/pkgs/applications/networking/browsers/kristall/default.nix b/pkgs/applications/networking/browsers/kristall/default.nix index 4028f8622c3c..1ec6a6e36406 100644 --- a/pkgs/applications/networking/browsers/kristall/default.nix +++ b/pkgs/applications/networking/browsers/kristall/default.nix @@ -1,31 +1,44 @@ -{ lib, mkDerivation, fetchFromGitHub, qtbase, qtmultimedia }: +{ lib, stdenv, mkDerivation, fetchFromGitHub, qmake, qtmultimedia }: mkDerivation rec { pname = "kristall"; version = "0.3"; + src = fetchFromGitHub { owner = "MasterQ32"; repo = "kristall"; - rev = "V" + version; + rev = "V${version}"; sha256 = "07nf7w6ilzs5g6isnvsmhh4qa1zsprgjyf0zy7rhpx4ikkj8c8zq"; }; - buildInputs = [ qtbase qtmultimedia ]; + postPatch = lib.optionalString stdenv.cc.isClang '' + sed -i '1i #include ' src/browsertab.cpp + ''; + + nativeBuildInputs = [ qmake ]; + + buildInputs = [ qtmultimedia ]; qmakeFlags = [ "src/kristall.pro" ]; - installPhase = '' + installPhase = if stdenv.isDarwin then '' + mkdir -p $out/Applications + mv kristall.app $out/Applications + '' else '' install -Dt $out/bin kristall install -D Kristall.desktop $out/share/applications/net.random-projects.kristall.desktop + install -D src/icons/kristall.svg $out/share/icons/hicolor/scalable/apps/net.random-projects.kristall.svg + for size in 16 32 64 128; do + install -D src/icons/kristall-''${size}.png $out/share/icons/hicolor/''${size}x''${size}/apps/net.random-projects.kristall.png + done ''; - meta = with lib; - src.meta // { - description = - "Graphical small-internet client, supports gemini, http, https, gopher, finger"; - homepage = "https://random-projects.net/projects/kristall.gemini"; - maintainers = with maintainers; [ ehmry ]; - license = licenses.gpl3; - inherit (qtmultimedia.meta) platforms; - }; + meta = with lib; { + description = + "Graphical small-internet client, supports gemini, http, https, gopher, finger"; + homepage = "https://random-projects.net/projects/kristall.gemini"; + maintainers = with maintainers; [ ehmry ]; + license = licenses.gpl3Only; + inherit (qtmultimedia.meta) platforms; + }; } From 4d01b4ac9bfc6202ef7874fbb1897cec1b37953c Mon Sep 17 00:00:00 2001 From: Dmitry Kalinkin Date: Thu, 18 Nov 2021 16:35:08 -0500 Subject: [PATCH 2/4] kristall: don't use libsForQt5.mkDerivation --- pkgs/applications/networking/browsers/kristall/default.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/applications/networking/browsers/kristall/default.nix b/pkgs/applications/networking/browsers/kristall/default.nix index 1ec6a6e36406..9cf8c271b52c 100644 --- a/pkgs/applications/networking/browsers/kristall/default.nix +++ b/pkgs/applications/networking/browsers/kristall/default.nix @@ -1,6 +1,6 @@ -{ lib, stdenv, mkDerivation, fetchFromGitHub, qmake, qtmultimedia }: +{ lib, stdenv, fetchFromGitHub, qmake, qtmultimedia }: -mkDerivation rec { +stdenv.mkDerivation rec { pname = "kristall"; version = "0.3"; From 8d904c69010c556b86531e23c0bf762f8c378bc3 Mon Sep 17 00:00:00 2001 From: Dmitry Kalinkin Date: Thu, 18 Nov 2021 16:49:34 -0500 Subject: [PATCH 3/4] kristal: add wrapQtAppsHook --- pkgs/applications/networking/browsers/kristall/default.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/applications/networking/browsers/kristall/default.nix b/pkgs/applications/networking/browsers/kristall/default.nix index 9cf8c271b52c..c085f569a13c 100644 --- a/pkgs/applications/networking/browsers/kristall/default.nix +++ b/pkgs/applications/networking/browsers/kristall/default.nix @@ -15,7 +15,7 @@ stdenv.mkDerivation rec { sed -i '1i #include ' src/browsertab.cpp ''; - nativeBuildInputs = [ qmake ]; + nativeBuildInputs = [ wrapQtAppsHook qmake ]; buildInputs = [ qtmultimedia ]; From e40599d46b5e99f58ac473258474791fe04f22cc Mon Sep 17 00:00:00 2001 From: Dmitry Kalinkin Date: Thu, 18 Nov 2021 16:54:33 -0500 Subject: [PATCH 4/4] kristal: add missing wrapQtAppsHook argument --- pkgs/applications/networking/browsers/kristall/default.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/applications/networking/browsers/kristall/default.nix b/pkgs/applications/networking/browsers/kristall/default.nix index c085f569a13c..1435d2472635 100644 --- a/pkgs/applications/networking/browsers/kristall/default.nix +++ b/pkgs/applications/networking/browsers/kristall/default.nix @@ -1,4 +1,4 @@ -{ lib, stdenv, fetchFromGitHub, qmake, qtmultimedia }: +{ lib, stdenv, fetchFromGitHub, wrapQtAppsHook, qmake, qtmultimedia }: stdenv.mkDerivation rec { pname = "kristall";