From 73b373aa6aa15e09937f1ea3f956d85355ae9578 Mon Sep 17 00:00:00 2001 From: Sarah Clark Date: Mon, 19 May 2025 12:52:48 -0700 Subject: [PATCH 1/2] python3Packages.firebase-admin: add sarahec as maintainer --- pkgs/development/python-modules/firebase-admin/default.nix | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pkgs/development/python-modules/firebase-admin/default.nix b/pkgs/development/python-modules/firebase-admin/default.nix index 853b5a25c68b..cc88966e4478 100644 --- a/pkgs/development/python-modules/firebase-admin/default.nix +++ b/pkgs/development/python-modules/firebase-admin/default.nix @@ -61,6 +61,9 @@ buildPythonPackage rec { homepage = "https://github.com/firebase/firebase-admin-python"; changelog = "https://github.com/firebase/firebase-admin-python/releases/tag/${src.tag}"; license = lib.licenses.asl20; - maintainers = with lib.maintainers; [ jhahn ]; + maintainers = with lib.maintainers; [ + jhahn + sarahec + ]; }; } From 06ac85fdd2e4cdb245eafc30170f1340c4447707 Mon Sep 17 00:00:00 2001 From: Sarah Clark Date: Fri, 16 May 2025 17:10:26 -0700 Subject: [PATCH 2/2] python3Packages.firebase-admin: test fixes --- .../python-modules/firebase-admin/default.nix | 21 ++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/pkgs/development/python-modules/firebase-admin/default.nix b/pkgs/development/python-modules/firebase-admin/default.nix index cc88966e4478..4d87e969cec1 100644 --- a/pkgs/development/python-modules/firebase-admin/default.nix +++ b/pkgs/development/python-modules/firebase-admin/default.nix @@ -4,7 +4,6 @@ buildPythonPackage, fetchFromGitHub, setuptools, - hatchling, cachecontrol, cryptography, google-api-python-client, @@ -13,6 +12,7 @@ pyjwt, requests, pytestCheckHook, + pytest-asyncio, pytest-localserver, pytest-mock, }: @@ -43,18 +43,25 @@ buildPythonPackage rec { nativeCheckInputs = [ pytestCheckHook + pytest-asyncio pytest-localserver pytest-mock ]; __darwinAllowLocalNetworking = true; - disabledTests = [ - # Flaky (AssertionError) - # > assert delta <= timedelta(seconds=15) - # E assert datetime.timedelta(seconds=17, microseconds=28239) <= datetime.timedelta(seconds=15) - "test_task_options" - ]; + disabledTests = + [ + # Flaky (AssertionError) + # > assert delta <= timedelta(seconds=15) + # E assert datetime.timedelta(seconds=17, microseconds=28239) <= datetime.timedelta(seconds=15) + "test_task_options" + ] + ++ lib.optionals stdenv.hostPlatform.isDarwin [ + # Flaky / timing sensitive + "test_expired_cookie_with_tolerance" + "test_expired_token_with_tolerance" + ]; meta = { description = "Firebase Admin Python SDK";